Skip to content

Commit a536a58

Browse files
authored
Merge pull request #407 from rumpl/fix-global-server
Fix the oauth callback server
2 parents e877b5f + f2c662c commit a536a58

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

pkg/oauth/manager.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -183,12 +183,16 @@ func (m *manager) performOAuthAuthorization(ctx context.Context, sessionID strin
183183
slog.Debug("Waiting for OAuth authorization code")
184184
var code string
185185

186-
// Ensure callback server is started if needed
187-
if err := m.ensureCallbackServer(ctx); err != nil {
188-
slog.Warn("Failed to start callback server, falling back to manual input", "error", err)
189-
}
190-
191186
if m.managedServer {
187+
// Ensure callback server is started if needed
188+
if err := m.ensureCallbackServer(ctx); err != nil {
189+
slog.Warn("Failed to start callback server, falling back to manual input", "error", err)
190+
}
191+
192+
defer func() {
193+
SetGlobalCallbackServer(nil)
194+
}()
195+
192196
// Check if we have a callback server running (either global or our own)
193197
if callbackServer := m.getCallbackServer(); callbackServer != nil {
194198
slog.Debug("Using callback server for OAuth authorization")

0 commit comments

Comments
 (0)