Commit 688245d
authored
[trimming] remove our usage of
Fixes: #5197
`[Preserve]` still works in some form, as the `ApplyPreserveAttribute`
trimmer step will "mark" types it encounters. It unfortuantely, *does
not* work if an assembly is deemed to be fully removed, as the
`ApplyPreserveAttribute` will not be called for these types.
To better align with the future of .NET, we should remove *our* usage of
`[Preserve]`. The only failing result is `Java.Lang.Object.SetHandleOnDeserialized`
which can be preserved in `Mono.Android.xml` instead.
In a future PR, we can consider emitting warnings in customer code with
`[Preserve]` usage.[Preserve] (#9126)1 parent 5feae81 commit 688245d
File tree
6 files changed
+1
-11
lines changed- src
- Microsoft.Android.Sdk.ILLink/PreserveLists
- Mono.Android
- Android.OS
- Android.Runtime
- Java.Lang
6 files changed
+1
-11
lines changedLines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | 67 | | |
69 | 68 | | |
70 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| |||
387 | 386 | | |
388 | 387 | | |
389 | 388 | | |
390 | | - | |
391 | 389 | | |
392 | 390 | | |
393 | 391 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
130 | | - | |
131 | 129 | | |
132 | 130 | | |
133 | 131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
86 | 85 | | |
87 | 86 | | |
88 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
852 | 852 | | |
853 | 853 | | |
854 | 854 | | |
855 | | - | |
856 | | - | |
857 | | - | |
858 | | - | |
859 | | - | |
860 | 855 | | |
861 | 856 | | |
862 | 857 | | |
| |||
0 commit comments