update to use minidump

Author: max-charlamb

src/SOS/SOS.UnitTests/Debuggees/TriageDumpLocalVarLookup/TriageDumpLocalVarLookup.csproj renamed to src/SOS/SOS.UnitTests/Debuggees/MiniDumpLocalVarLookup/MiniDumpLocalVarLookup.csproj

@@ -4,7 +4,7 @@
 using System;
 using System.Diagnostics;
 
-namespace TriageDumpLocalVarLookup;
+namespace MiniDumpLocalVarLookup;
 
 internal class Program
 {

src/SOS/SOS.UnitTests/Debuggees/TriageDumpLocalVarLookup/Program.cs renamed to src/SOS/SOS.UnitTests/Debuggees/MiniDumpLocalVarLookup/Program.cs

@@ -140,6 +140,7 @@ internal static async Task RunTest(
         bool testLive = true,
         bool testDump = true,
         bool testTriage = false,
+        bool testMini = false,
         SOSRunner.DumpGenerator dumpGenerator = SOSRunner.DumpGenerator.CreateDump)
     {
         await RunTest(scriptName,
@@ -172,6 +173,21 @@ await RunTest(scriptName,
                 },
                 output);
         }
+        if (testMini && !config.PublishSingleFile)
+        {
+            await RunTest(scriptName,
+                new SOSRunner.TestInformation
+                {
+                    TestConfiguration = config,
+                    TestName = testName,
+                    TestLive = false,
+                    TestDump = testDump,
+                    DebuggeeName = debuggeeName,
+                    DumpType = SOSRunner.DumpType.Mini,
+                    DumpGenerator = dumpGenerator,
+                },
+                output);
+        }
     }
 
     internal static void TestCrashReport(string dumpName, SOSRunner.TestInformation information)
@@ -238,18 +254,28 @@ public SOS(ITestOutputHelper output)
     public static IEnumerable<object[]> Configurations => SOSTestHelpers.GetConfigurations("TestName", value: null);
 
     [SkippableTheory, MemberData(nameof(SOSTestHelpers.GetNetCoreConfigurations), MemberType = typeof(SOSTestHelpers))]
-    public async Task TriageDumpLocalVarLookup(TestConfiguration config)
+    public async Task MiniDumpLocalVarLookup(TestConfiguration config)
     {
+        if (OS.Kind != OSKind.Windows)
+        {
+            throw new SkipTestException("Test only supports CDB and therefore only runs on Windows");
+        }
+
+        if (config.PublishSingleFile)
+        {
+            throw new SkipTestException("Single file does not support mini dumps");
+        }
+
         // The default dumpGenerator, CreateDump, only supports taking dumps at exceptions.
         // DotnetDump could support taking a dump at a breakpoint, but this SOS test framework doesn't currently support this operation.
         // Therefore we use the NativeDebugger to take a dump at the DebugBreak() call in the debuggee.
         await SOSTestHelpers.RunTest(
             config,
-            debuggeeName: "TriageDumpLocalVarLookup",
-            scriptName: "TriageDumpLocalVarLookup.script",
+            debuggeeName: "MiniDumpLocalVarLookup",
+            scriptName: "MiniDumpLocalVarLookup.script",
             Output,
-            testName: "SOS.TriageDumpLocalVarLookup",
-            testTriage: true,
+            testName: "SOS.MiniDumpLocalVarLookup",
+            testMini: true,
             dumpGenerator: SOSRunner.DumpGenerator.NativeDebugger);
     }
 

src/SOS/SOS.UnitTests/SOS.cs

@@ -34,6 +34,7 @@ public enum DumpGenerator
     public enum DumpType
     {
         Triage,
+        Mini,
         Heap,
         Full
     }
@@ -235,6 +236,9 @@ public static async Task<string> CreateDump(TestInformation information)
                         await runner.ContinueExecution();
                         switch (information.DumpType)
                         {
+                            case DumpType.Mini:
+                                command = ".dump /o /m %DUMP_NAME%";
+                                break;
                             case DumpType.Heap:
                                 command = ".dump /o /mw %DUMP_NAME%";
                                 break;
@@ -349,6 +353,9 @@ public static async Task<string> CreateDump(TestInformation information)
                     }
                     switch (dumpType)
                     {
+                        case DumpType.Mini:
+                            processRunner.WithRuntimeConfiguration("DbgMiniDumpType", "1");
+                            break;
                         case DumpType.Heap:
                             processRunner.WithRuntimeConfiguration("DbgMiniDumpType", "2");
                             break;
@@ -1498,6 +1505,9 @@ private HashSet<string> GetEnabledDefines()
         {
             switch (_dumpType.Value)
             {
+                case DumpType.Mini:
+                    defines.Add("MINI_DUMP");
+                    break;
                 case DumpType.Triage:
                     defines.Add("TRIAGE_DUMP");
                     break;