Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

  • Document Page class navigation events from dotnet/maui PR Keyboard auto scroll manager on iOS #1812
    • Events: NavigatedTo, NavigatingFrom, NavigatedFrom
    • Virtual methods: OnNavigatedTo, OnNavigatingFrom, OnNavigatedFrom
  • Document .NET 10 navigation event args properties using moniker ranges
    • NavigatedToEventArgs: PreviousPage, NavigationType
    • NavigatingFromEventArgs: DestinationPage, NavigationType
    • NavigatedFromEventArgs: DestinationPage, NavigationType
    • NavigationType enum: Push, Pop, PopToRoot, Insert, Remove, Replace
  • Code review feedback addressed
    • Use xref markup for NavigationType type references
    • Improved example introductory text

Summary

  • Added "Page navigation events" section to docs/user-interface/pages/navigationpage.md
  • Uses moniker ranges to show .NET 9 and earlier simple examples, and .NET 10+ examples with the new properties
  • Documents all properties on the three EventArgs classes
  • Documents all values of the NavigationType enumeration
Original prompt

This section details on the original issue you should resolve

<issue_title>Page navigating events</issue_title>
<issue_description>The Page class exposes navigation events and overrides: dotnet/maui#1812

These need documenting.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@learn-build-service-prod
Copy link

Learn Build status updates of commit a6ce63e:

✅ Validation status: passed

For more details, please refer to the build report.

@learn-build-service-prod
Copy link

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 1cb6b63:

✅ Validation status: passed

File Status Preview URL Details
docs/user-interface/pages/navigationpage.md ✅Succeeded View (>=net-maui-8.0)

For more details, please refer to the build report.

@learn-build-service-prod
Copy link

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 1cb6b63:

✅ Validation status: passed

File Status Preview URL Details
docs/user-interface/pages/navigationpage.md ✅Succeeded View (>=net-maui-8.0)

For more details, please refer to the build report.

Copilot AI changed the title [WIP] Add documentation for page navigating events Document Page navigation events (NavigatedTo, NavigatingFrom, NavigatedFrom) Nov 28, 2025
Copilot AI requested a review from PureWeen November 28, 2025 23:24
Copilot finished work on behalf of PureWeen November 28, 2025 23:24
@PureWeen
Copy link
Member

@copilot can you check to see if all the new properties that were added to the various nav args in net10 have all been documented?

Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

@copilot can you check to see if all the new properties that were added to the various nav args in net10 have all been documented?

Added documentation for the .NET 10 navigation event args properties in commit d1afb7a:

  • NavigatedToEventArgs: PreviousPage, NavigationType
  • NavigatingFromEventArgs: DestinationPage, NavigationType
  • NavigatedFromEventArgs: DestinationPage, NavigationType
  • NavigationType enum: Push, Pop, PopToRoot, Insert, Remove, Replace

Used moniker ranges to show version-specific examples (simple examples for .NET 9 and earlier, expanded examples showing the new properties for .NET 10+).

@learn-build-service-prod
Copy link

Learn Build status updates of commit d1afb7a:

✅ Validation status: passed

File Status Preview URL Details
docs/user-interface/pages/navigationpage.md ✅Succeeded View (>=net-maui-8.0)

For more details, please refer to the build report.

@learn-build-service-prod
Copy link

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 6761a3e:

✅ Validation status: passed

File Status Preview URL Details
docs/user-interface/pages/navigationpage.md ✅Succeeded View (>=net-maui-8.0)

For more details, please refer to the build report.

Copilot finished work on behalf of PureWeen November 28, 2025 23:47
@PureWeen
Copy link
Member

@copilot did you verify these properties aren't anywhere else in our docs?

Copy link
Contributor Author

Copilot AI commented Nov 29, 2025

@copilot did you verify these properties aren't anywhere else in our docs?

I verified these properties aren't documented anywhere else in the docs. Searched the repository and found:

  • NavigatedToEventArgs - only appears in a tutorial code snippet (AllNotesPage.xaml.cs) that uses the event but doesn't document properties
  • NavigatingFromEventArgs - not found elsewhere
  • NavigatedFromEventArgs - not found elsewhere
  • NavigationType enum - not found elsewhere
  • PreviousPage property - not found elsewhere
  • DestinationPage property - not found elsewhere

The documentation I added in navigationpage.md is the only place these .NET 10 properties are documented.

Copilot finished work on behalf of PureWeen November 29, 2025 00:43
@PureWeen PureWeen marked this pull request as ready for review November 29, 2025 04:53
@PureWeen PureWeen requested a review from a team as a code owner November 29, 2025 04:53
@PureWeen PureWeen requested a review from jfversluis November 29, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page navigating events

2 participants