Update external dependencies (#2128)

pgrawehr · joperezr · web-flow · commit 6b827cd0a3e9 · 2023-11-16T16:19:31.000+01:00
* Update external dependencies

* Minor issues with new Analyzers

* Fix obsolete functions

---------

Co-authored-by: Jose Perez Rodriguez &lt;joperezr@microsoft.com&gt;
diff --git a/eng/Analyzers.props b/eng/Analyzers.props
@@ -8,7 +8,7 @@ file which is not marked as such, making StyleCop fail. -->
   </PropertyGroup>
   <ItemGroup Condition="'$(MSBuildProjectExtension)' == '.csproj'">
     <AdditionalFiles Include="$(MSBuildThisFileDirectory)\stylecop.json" Link="stylecop.json" />
-    <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.333">
+    <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.435">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
diff --git a/eng/StyleCop.Analyzers.ruleset b/eng/StyleCop.Analyzers.ruleset
@@ -136,7 +136,7 @@
     <Rule Id="SA1515" Action="None" /> <!-- Single-line comment should be preceded by blank line -->
     <Rule Id="SA1516" Action="None" /> <!-- Elements should be separated by blank line -->
     <Rule Id="SA1517" Action="Error" />
-    <Rule Id="SA1518" Action="Error" />
+    <Rule Id="SA1518" Action="None" /> <!-- Files must end with exactly one newline -->
     <Rule Id="SA1519" Action="Error" />
     <Rule Id="SA1520" Action="Error" />
     <Rule Id="SA1600" Action="None" />  <!-- Elements should be documented -->
diff --git a/eng/Versions.external.props b/eng/Versions.external.props
@@ -1,18 +1,19 @@
 <Project>
   <!-- These references to third-party libraries are included in all projects except System.Device.Gpio and the build wrapper project -->
   <ItemGroup Condition="'$(MSBuildProjectName)' != 'System.Device.Gpio' And '$(MSBuildProjectName)' != 'build'">
-    <PackageReference Include="UnitsNet" Version="5.1.0" />
+    <PackageReference Include="UnitsNet" Version="5.31.0" />
   </ItemGroup>
 
   <!-- Automatically include these assemblies in all test projects -->
   <ItemGroup Condition="$(MSBuildProjectName.EndsWith('Tests'))">
      <PackageReference Include="Moq" Version="4.16.1" />
-     <PackageReference Include="xunit" Version="2.4.1" />
-     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
+     <PackageReference Include="xunit" Version="2.5.0" />
+     <PackageReference Include="xunit.runner.visualstudio" Version="2.5.0">
        <PrivateAssets>all</PrivateAssets>
        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="xunit.runner.utility" Version="2.4.1" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
+    <PackageReference Include="xunit.runner.utility" Version="2.5.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
+    <PackageReference Include="Shouldly" Version="4.2.1" />
   </ItemGroup>
 </Project>
diff --git a/src/System.Device.Gpio.Tests/GpioPinTests.cs b/src/System.Device.Gpio.Tests/GpioPinTests.cs
@@ -37,7 +37,7 @@ public void TestOpenPin()
             // Act
             GpioPin pin = ctrl.OpenPin(PinNumber, PinMode.Input);
             // Assert
-            Assert.Equal(pin.PinNumber, PinNumber);
+            Assert.Equal(PinNumber, pin.PinNumber);
             Assert.Equal(PinMode.Input, pin.GetPinMode());
         }
 
diff --git a/src/devices/Ags01db/Ags01db.csproj b/src/devices/Ags01db/Ags01db.csproj
@@ -11,4 +11,4 @@
     <None Remove="README.md" />
     <None Remove="sensor.jpg" />
   </ItemGroup>
-</Project>
+</Project>
diff --git a/src/devices/Ags01db/Register.cs b/src/devices/Ags01db/Register.cs
@@ -10,4 +10,4 @@ internal enum Register : byte
         ASG_VERSION_MSB = 0x0A,
         ASG_VERSION_LSB = 0x01
     }
-}
+}
diff --git a/src/devices/Button/tests/Button.tests.csproj b/src/devices/Button/tests/Button.tests.csproj
@@ -8,19 +8,6 @@
     <RootNamespace>Iot.Device.Button.Tests</RootNamespace>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
-    <PackageReference Include="xunit" Version="2.4.1" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="3.0.2">
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\Button.csproj" />
   </ItemGroup>
diff --git a/src/devices/Card/Ndef/tests/Ndef.Tests.csproj b/src/devices/Card/Ndef/tests/Ndef.Tests.csproj
@@ -5,10 +5,6 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="coverlet.collector" Version="1.2.0" />
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\Ndef.csproj" />
   </ItemGroup>
diff --git a/src/devices/HardwareMonitor/OpenHardwareMonitor.cs b/src/devices/HardwareMonitor/OpenHardwareMonitor.cs
@@ -593,7 +593,7 @@ private void MonitorThread()
         /// <exception cref="ArgumentOutOfRangeException"><paramref name="monitoringInterval"/> is less than 0.</exception>
         public void EnableDerivedSensors(Area cpuDieSize = default, TimeSpan monitoringInterval = default)
         {
-            if (cpuDieSize.Equals(Area.Zero, 0, ComparisonType.Absolute))
+            if (cpuDieSize.Equals(Area.Zero, Area.Zero))
             {
                 // Values for some recent intel chips (coffee lake)
                 if (LogicalProcessors <= 4)
diff --git a/src/devices/Nmea0183/tests/Ais/AisTargetTests.cs b/src/devices/Nmea0183/tests/Ais/AisTargetTests.cs
@@ -48,8 +48,8 @@ public void ExtrapolatePositionWithRotation()
             ship.RateOfTurn = RotationalSpeed.FromDegreesPerMinute(10);
             ship2 = ship.EstimatePosition(TimeSpan.FromMinutes(10), TimeSpan.FromSeconds(20));
             Assert.Equal(Angle.FromDegrees(100).Value, ship2.CourseOverGround.Value, 3);
-            Assert.Equal(45.015124163, ship2.Position.Latitude, 9);
-            Assert.Equal(9.026965951, ship2.Position.Longitude, 9);
+            Assert.Equal(45.015124163, ship2.Position.Latitude, 7);
+            Assert.Equal(9.026965951, ship2.Position.Longitude, 7);
         }
 
         [Fact]
@@ -81,8 +81,8 @@ public void ExtrapolatePositionWithRotationAndGivenTime()
             var ship2 = ship.EstimatePosition(t + TimeSpan.FromMinutes(10), TimeSpan.FromSeconds(20));
             Assert.Equal(t + TimeSpan.FromMinutes(10), ship2.LastSeen);
             Assert.Equal(Angle.FromDegrees(100).Value, ship2.CourseOverGround.Value, 3);
-            Assert.Equal(45.015124163, ship2.Position.Latitude, 9);
-            Assert.Equal(9.026965951, ship2.Position.Longitude, 9);
+            Assert.Equal(45.015124163, ship2.Position.Latitude, 7);
+            Assert.Equal(9.026965951, ship2.Position.Longitude, 7);
         }
     }
 }
diff --git a/src/devices/Nmea0183/tests/Nmea0183.Tests.csproj b/src/devices/Nmea0183/tests/Nmea0183.Tests.csproj
@@ -38,8 +38,5 @@
   <ItemGroup>
     <ProjectReference Include="..\Nmea0183.csproj" />
   </ItemGroup>
-  <ItemGroup>
-    <PackageReference Include="Shouldly" Version="4.0.3" />
-  </ItemGroup>
 
 </Project>
diff --git a/src/devices/Nmea0183/tests/SentenceTests.cs b/src/devices/Nmea0183/tests/SentenceTests.cs
@@ -285,7 +285,7 @@ public void XteDecode()
             CrossTrackError xte = (CrossTrackError)decoded!.TryGetTypedValue(ref _lastPacketTime)!;
 
             Assert.True(xte.Valid);
-            Assert.True(xte.Distance.Equals(Length.Zero, 0, ComparisonType.Absolute));
+            Assert.True(xte.Distance.Equals(Length.Zero, Length.Zero));
         }
 
         [Fact]
diff --git a/tools/ArduinoCsCompiler/ArduinoCsCompiler.csproj b/tools/ArduinoCsCompiler/ArduinoCsCompiler.csproj
@@ -24,7 +24,7 @@
    </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="3.10.0" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="4.5.0" />
     <ProjectReference Include="..\..\src\devices\Arduino\Arduino.csproj" />
     <ProjectReference Include="..\..\src\System.Device.Gpio\System.Device.Gpio.csproj" />
   </ItemGroup>
diff --git a/tools/ArduinoCsCompiler/Frontend/CompilerRun.cs b/tools/ArduinoCsCompiler/Frontend/CompilerRun.cs
@@ -67,7 +67,7 @@ public override bool RunCommand()
                 Logger.LogInformation($"Recommended minimum values are 512 kB of flash and 100 kB of RAM. Some microcontrollers (e.g. ESP32) may allow configuration of the amount of flash " +
                                       $"available for code.");
 
-                if (!caps.IntSize.Equals(Information.FromBytes(4), 0, ComparisonType.Absolute) || !caps.PointerSize.Equals(Information.FromBytes(4), 0, ComparisonType.Absolute))
+                if (!caps.IntSize.Equals(Information.FromBytes(4), Information.Zero) || !caps.PointerSize.Equals(Information.FromBytes(4), Information.Zero))
                 {
                     Logger.LogWarning("Board pointer and/or integer size is not 32 bits. This is untested and may lead to unpredictable behavior.");
                 }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public void TestOpenPin()`
`37`	`37`	`// Act`
`38`	`38`	`GpioPin pin = ctrl.OpenPin(PinNumber, PinMode.Input);`
`39`	`39`	`// Assert`
`40`		`- Assert.Equal(pin.PinNumber, PinNumber);`
	`40`	`+ Assert.Equal(PinNumber, pin.PinNumber);`
`41`	`41`	`Assert.Equal(PinMode.Input, pin.GetPinMode());`
`42`	`42`	`}`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,4 @@ internal enum Register : byte`
`10`	`10`	`ASG_VERSION_MSB = 0x0A,`
`11`	`11`	`ASG_VERSION_LSB = 0x01`
`12`	`12`	`}`
`13`		`-}`
	`13`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -593,7 +593,7 @@ private void MonitorThread()`
`593`	`593`	`/// <exception cref="ArgumentOutOfRangeException"><paramref name="monitoringInterval"/> is less than 0.</exception>`
`594`	`594`	`public void EnableDerivedSensors(Area cpuDieSize = default, TimeSpan monitoringInterval = default)`
`595`	`595`	`{`
`596`		`- if (cpuDieSize.Equals(Area.Zero, 0, ComparisonType.Absolute))`
	`596`	`+ if (cpuDieSize.Equals(Area.Zero, Area.Zero))`
`597`	`597`	`{`
`598`	`598`	`// Values for some recent intel chips (coffee lake)`
`599`	`599`	`if (LogicalProcessors <= 4)`
Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,8 @@ public void ExtrapolatePositionWithRotation()`
`48`	`48`	`ship.RateOfTurn = RotationalSpeed.FromDegreesPerMinute(10);`
`49`	`49`	`ship2 = ship.EstimatePosition(TimeSpan.FromMinutes(10), TimeSpan.FromSeconds(20));`
`50`	`50`	`Assert.Equal(Angle.FromDegrees(100).Value, ship2.CourseOverGround.Value, 3);`
`51`		`- Assert.Equal(45.015124163, ship2.Position.Latitude, 9);`
`52`		`- Assert.Equal(9.026965951, ship2.Position.Longitude, 9);`
	`51`	`+ Assert.Equal(45.015124163, ship2.Position.Latitude, 7);`
	`52`	`+ Assert.Equal(9.026965951, ship2.Position.Longitude, 7);`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`[Fact]`
`@@ -81,8 +81,8 @@ public void ExtrapolatePositionWithRotationAndGivenTime()`
`81`	`81`	`var ship2 = ship.EstimatePosition(t + TimeSpan.FromMinutes(10), TimeSpan.FromSeconds(20));`
`82`	`82`	`Assert.Equal(t + TimeSpan.FromMinutes(10), ship2.LastSeen);`
`83`	`83`	`Assert.Equal(Angle.FromDegrees(100).Value, ship2.CourseOverGround.Value, 3);`
`84`		`- Assert.Equal(45.015124163, ship2.Position.Latitude, 9);`
`85`		`- Assert.Equal(9.026965951, ship2.Position.Longitude, 9);`
	`84`	`+ Assert.Equal(45.015124163, ship2.Position.Latitude, 7);`
	`85`	`+ Assert.Equal(9.026965951, ship2.Position.Longitude, 7);`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`	`}`