Skip to content

Commit 900e4f6

Browse files
Copilotagocke
andcommitted
Address PR feedback: use CurrentTargetFramework and more contrasting path identifier
- Changed from testing all Net7Plus frameworks to only CurrentTargetFramework - Removed unnecessary macOS/net7.0 platform check - Changed identifier from "with space" to "path with spaces" for better contrast Co-authored-by: agocke <[email protected]>
1 parent 089797c commit 900e4f6

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,9 @@ public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled(string
7878
}
7979

8080
[RequiresMSBuildVersionTheory("17.12.0", Skip = "https://github.com/dotnet/sdk/issues/46006")]
81-
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
81+
[InlineData(ToolsetInfo.CurrentTargetFramework)]
8282
public void NativeAot_app_publishes_with_space_in_path(string targetFramework)
8383
{
84-
if (targetFramework == "net7.0" && RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
85-
{
86-
// 7.0 is not supported on Mac
87-
return;
88-
}
89-
9084
var projectName = "HelloWorldNativeAotApp";
9185

9286
var testProject = CreateHelloWorldTestProject(targetFramework, projectName, true);
@@ -99,7 +93,7 @@ public void NativeAot_app_publishes_with_space_in_path(string targetFramework)
9993
testProject.AdditionalProperties["StripSymbols"] = "true";
10094
}
10195
// Use an identifier with a space to create a path with a space
102-
var testAsset = _testAssetsManager.CreateTestProject(testProject, identifier: "with space");
96+
var testAsset = _testAssetsManager.CreateTestProject(testProject, identifier: "path with spaces");
10397

10498
var publishCommand = new PublishCommand(Log, Path.Combine(testAsset.TestRoot, testProject.Name));
10599
publishCommand

0 commit comments

Comments
 (0)