-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enable assetless builds and clean up YAMLs #11290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- azure-pipelines1.yml no longer used. - PR/CI and non-PR scenarios were split into two yamls, so no need to have two eng/pipeline* yamls. Instead, put logic into root yamls. - Make official build assetless. Keep option for Loc. - Clean up PR yaml. Ensure that helix testing is actually running on internal PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR streamlines Azure DevOps pipelines by removing obsolete templates, consolidating PR vs. non-PR logic, enabling assetless official builds, and ensuring Helix tests run for internal PRs.
- Remove eng/pipeline.yml, eng/pipeline-pr.yml, and azure-pipelines1.yml in favor of simplified root YAMLs
- Make official builds assetless and split PR vs. non-PR scenarios into azure-pipelines.yml and azure-pipelines-pr.yml
- Ensure Helix testing and code coverage execution for internal PRs
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipeline.yml | Removed obsolete template-based pipeline (logic moved to root YAMLs). |
| eng/pipeline-pr.yml | Removed per-PR template in favor of consolidated PR pipeline in root. |
| azure-pipelines1.yml | Removed wrapper pipeline no longer needed due to simplified logic. |
| azure-pipelines.yml | Implements assetless official build, consolidates non-PR logic, adds OneLocBuild on main branch, and configures jobs.yml parameters. |
| azure-pipelines-pr.yml | Defines PR build and test matrix, Helix configuration, and coverage publishing for PR scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
Hi @mmitche, checking on the PR status. Can you please look at the pointers above. Thanks. |
|
@harshit7962 updated. |
This reverts commit e22c4f6.
harshit7962
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Microsoft Reviewers: Open in CodeFlow