Skip to content

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Nov 26, 2025

  • azure-pipelines1.yml no longer used.
  • PR/CI and non-PR scenarios were split into two yamls, so no need to have two eng/pipeline* yamls. Instead, put logic into root yamls.
  • Make official build assetless. Keep option for Loc.
  • Clean up PR yaml. Ensure that helix testing is actually running on internal PRs.
Microsoft Reviewers: Open in CodeFlow

- azure-pipelines1.yml no longer used.
- PR/CI and non-PR scenarios were split into two yamls, so no need to have two eng/pipeline* yamls. Instead, put logic into root yamls.
- Make official build assetless. Keep option for Loc.
- Clean up PR yaml. Ensure that helix testing is actually running on internal PRs.
Copilot AI review requested due to automatic review settings November 26, 2025 18:50
@mmitche mmitche requested a review from a team as a code owner November 26, 2025 18:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines Azure DevOps pipelines by removing obsolete templates, consolidating PR vs. non-PR logic, enabling assetless official builds, and ensuring Helix tests run for internal PRs.

  • Remove eng/pipeline.yml, eng/pipeline-pr.yml, and azure-pipelines1.yml in favor of simplified root YAMLs
  • Make official builds assetless and split PR vs. non-PR scenarios into azure-pipelines.yml and azure-pipelines-pr.yml
  • Ensure Helix testing and code coverage execution for internal PRs

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
eng/pipeline.yml Removed obsolete template-based pipeline (logic moved to root YAMLs).
eng/pipeline-pr.yml Removed per-PR template in favor of consolidated PR pipeline in root.
azure-pipelines1.yml Removed wrapper pipeline no longer needed due to simplified logic.
azure-pipelines.yml Implements assetless official build, consolidates non-PR logic, adds OneLocBuild on main branch, and configures jobs.yml parameters.
azure-pipelines-pr.yml Defines PR build and test matrix, Helix configuration, and coverage publishing for PR scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 26, 2025
@harshit7962
Copy link
Member

Hi @mmitche, checking on the PR status. Can you please look at the pointers above. Thanks.

@mmitche
Copy link
Member Author

mmitche commented Dec 8, 2025

@mmitche
Copy link
Member Author

mmitche commented Dec 8, 2025

@harshit7962 updated.

@mmitche
Copy link
Member Author

mmitche commented Dec 8, 2025

https://dev.azure.com/dnceng/internal/_build/results?buildId=2856474&view=results

Copy link
Member

@harshit7962 harshit7962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit7962 harshit7962 merged commit 37b9597 into dotnet:main Dec 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants