fix: enhance ArrayToArrGetRector to skip isset, empty checks, and assignments

Author: MrPunyapal

src/Rector/ArrayDimFetch/ArrayToArrGetRector.php

@@ -8,7 +8,11 @@
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\ArrayDimFetch;
+use PhpParser\Node\Expr\Assign;
+use PhpParser\Node\Expr\AssignOp;
 use PhpParser\Node\Expr\BinaryOp\Coalesce;
+use PhpParser\Node\Expr\Empty_;
+use PhpParser\Node\Expr\Isset_;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Throw_;
 use PhpParser\Node\Name\FullyQualified;
@@ -31,21 +35,27 @@ final class ArrayToArrGetRector extends AbstractRector
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Convert array access to Arr::get() method call, skips null coalesce with throw expressions',
+            'Convert array access to Arr::get() method call, skips isset/empty checks, assignments, and null coalesce with throw expressions',
             [new CodeSample(
                 <<<'CODE_SAMPLE'
 $array['key'];
 $array['nested']['key'];
 $array['key'] ?? 'default';
 $array['nested']['key'] ?? 'default';
 $array['key'] ?? throw new Exception('Required');
+isset($array['key']);
+empty($array['key']);
+$array['key'] = 'value';
 CODE_SAMPLE,
                 <<<'CODE_SAMPLE'
 \Illuminate\Support\Arr::get($array, 'key');
 \Illuminate\Support\Arr::get($array, 'nested.key');
 \Illuminate\Support\Arr::get($array, 'key', 'default');
 \Illuminate\Support\Arr::get($array, 'nested.key', 'default');
 $array['key'] ?? throw new Exception('Required');
+isset($array['key']);
+empty($array['key']);
+$array['key'] = 'value';
 CODE_SAMPLE
             )]
         );
@@ -56,14 +66,33 @@ public function getRuleDefinition(): RuleDefinition
      */
     public function getNodeTypes(): array
     {
-        return [ArrayDimFetch::class, Coalesce::class];
+        return [ArrayDimFetch::class, Coalesce::class, Isset_::class, Empty_::class, Assign::class, AssignOp::class];
     }
 
     /**
-     * @param  ArrayDimFetch|Coalesce  $node
+     * @param  ArrayDimFetch|Coalesce|Isset_|Empty_|Assign|AssignOp  $node
      */
     public function refactor(Node $node): ?StaticCall
     {
+        if ($node instanceof Isset_) {
+            $this->markIssetArrayDimFetchesAsProcessed($node);
+            return null;
+        }
+
+        if ($node instanceof Empty_) {
+            if ($node->expr instanceof ArrayDimFetch) {
+                $this->markArrayDimFetchAsProcessed($node->expr);
+            }
+            return null;
+        }
+
+        if ($node instanceof Assign || $node instanceof AssignOp) {
+            if ($node->var instanceof ArrayDimFetch) {
+                $this->markArrayDimFetchAsProcessed($node->var);
+            }
+            return null;
+        }
+
         if ($node instanceof Coalesce) {
             $result = $this->refactorCoalesce($node);
             if ($result instanceof StaticCall && $node->left instanceof ArrayDimFetch) {
@@ -213,4 +242,13 @@ private function markArrayDimFetchAsProcessed(ArrayDimFetch $arrayDimFetch): voi
             $current = $current->var;
         }
     }
+
+    private function markIssetArrayDimFetchesAsProcessed(Isset_ $isset): void
+    {
+        foreach ($isset->vars as $var) {
+            if ($var instanceof ArrayDimFetch) {
+                $this->markArrayDimFetchAsProcessed($var);
+            }
+        }
+    }
 }

tests/Rector/ArrayDimFetch/ArrayToArrGetRector/Fixture/skip_compound_assignment.php.inc

@@ -0,0 +1,49 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\ArrayDimFetch\ArrayToArrGetRector\Fixture;
+
+class SkipCompoundAssignment
+{
+    public function run()
+    {
+        $array = ['count' => 5, 'value' => 10];
+
+        // Should skip compound assignment operators - no transformation
+        $array['count'] += 1;
+        $array['value'] -= 2;
+        $array['value'] *= 3;
+        $array['value'] /= 2;
+        $array['value'] %= 4;
+        $array['text'] .= ' appended';
+
+        // Should transform - normal read access
+        $value = $array['count'];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace RectorLaravel\Tests\Rector\ArrayDimFetch\ArrayToArrGetRector\Fixture;
+
+class SkipCompoundAssignment
+{
+    public function run()
+    {
+        $array = ['count' => 5, 'value' => 10];
+
+        // Should skip compound assignment operators - no transformation
+        $array['count'] += 1;
+        $array['value'] -= 2;
+        $array['value'] *= 3;
+        $array['value'] /= 2;
+        $array['value'] %= 4;
+        $array['text'] .= ' appended';
+
+        // Should transform - normal read access
+        $value = \Illuminate\Support\Arr::get($array, 'count');
+    }
+}
+
+?>

tests/Rector/ArrayDimFetch/ArrayToArrGetRector/Fixture/skip_isset_empty_assignment.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\ArrayDimFetch\ArrayToArrGetRector\Fixture;
+
+class SkipIssetEmptyAssignment
+{
+    public function run()
+    {
+        $array = ['key' => 'value', 'nested' => ['inner' => 'data']];
+
+        // Should skip isset checks - no transformation
+        if (isset($array['key'])) {
+            echo 'exists';
+        }
+
+        if (isset($array['nested']['inner'])) {
+            echo 'nested exists';
+        }
+
+        // Should skip empty checks - no transformation
+        if (empty($array['key'])) {
+            echo 'empty';
+        }
+
+        if (empty($array['nested']['inner'])) {
+            echo 'nested empty';
+        }
+
+        // Should skip assignment operations - no transformation
+        $array['key'] = 'new value';
+        $array['nested']['inner'] = 'new data';
+        $array['new_key'] = 'added';
+
+        // Should transform - normal read access
+        $value = \Illuminate\Support\Arr::get($array, 'key');
+        $nested = \Illuminate\Support\Arr::get($array, 'nested.inner');
+    }
+}
+
+?>