fix: ContainerBindConcreteWithClosureOnlyRector Rule when the abstract is a variable (#386)

* Update ContainerBindConcreteWithClosureOnlyRector Rule

Prevent changes when the abstract class is a variable.

* Update ContainerBindConcreteWithClosureOnlyRector Unit test

* Fix CS

---------

Co-authored-by: Jeff Meinesz <[email protected]>

Author: jf-m

src/Rector/MethodCall/ContainerBindConcreteWithClosureOnlyRector.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Const_;
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\Variable;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
@@ -74,6 +75,10 @@ public function refactor(Node $node): ?MethodCall
         $classString = $node->getArgs()[0]->value;
         $concreteNode = $node->getArgs()[1]->value;
 
+        if ($classString instanceof Variable) {
+            return null;
+        }
+
         if (! $concreteNode instanceof Closure) {
             return null;
         }

tests/Rector/MethodCall/ContainerBindConcreteWithClosureOnlyRector/Fixture/fixture.php.inc

@@ -19,6 +19,12 @@ $app->singleton(SomeInterface::class, function () {
     return new SomeClass();
 });
 
+foreach ([SomeClass::class] as $item) {
+    $app->singleton($item, function () use ($item) {
+        return new $item();
+    });
+}
+
 ?>
 -----
 <?php
@@ -42,4 +48,10 @@ $app->singleton(function (): \RectorLaravel\Tests\Rector\MethodCall\ContainerBin
     return new SomeClass();
 });
 
+foreach ([SomeClass::class] as $item) {
+    $app->singleton($item, function () use ($item) {
+        return new $item();
+    });
+}
+
 ?>