Add configured tests

Author: jradtilbrook

src/Rector/Class_/AddHasFactoryToModelsRector.php

@@ -15,6 +15,7 @@
 use Rector\Reflection\ReflectionResolver;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @changelog https://github.com/laravel/framework/pull/39310
@@ -26,7 +27,7 @@ final class AddHasFactoryToModelsRector extends AbstractRector implements Config
     private const string TRAIT_NAME = 'Illuminate\Database\Eloquent\Factories\HasFactory';
 
     /**
-     * @var mixed[]
+     * @var string[]
      */
     private array $allowList = [];
 
@@ -61,6 +62,7 @@ class User extends Model
 
     public function configure(array $configuration): void
     {
+        Assert::allString($configuration);
         $this->allowList = $configuration;
     }
 
@@ -91,11 +93,11 @@ public function refactor(Node $node): ?Node
     private function shouldSkipClass(Class_ $class): bool
     {
         if (! $this->isObjectType($class, new ObjectType('Illuminate\Database\Eloquent\Model'))) {
-            return null;
+            return false;
         }
 
         if ($this->allowList !== [] && ! $this->isNames($class, $this->allowList)) {
-            return false;
+            return true;
         }
 
         $classReflection = $this->reflectionResolver->resolveClassReflection($class);

tests/Rector/Class_/AddHasFactoryToModelsRectorConfigured/AddHasFactoryToModelsRectorConfiguredTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfigured;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class AddHasFactoryToModelsRectorConfiguredTest extends AbstractRectorTestCase
+{
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    /**
+     * @test
+     */
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Rector/Class_/AddHasFactoryToModelsRectorConfigured/Fixture/fixture.php.inc

@@ -0,0 +1,24 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfigured\Fixture;
+
+use Illuminate\Database\Eloquent\Model;
+
+class User extends Model
+{
+}
+
+?>
+-----
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfigured\Fixture;
+
+use Illuminate\Database\Eloquent\Model;
+
+class User extends Model
+{
+    use \Illuminate\Database\Eloquent\Factories\HasFactory;
+}
+
+?>

tests/Rector/Class_/AddHasFactoryToModelsRectorConfigured/Fixture/no_match.php.inc

@@ -0,0 +1,7 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfigured\Fixture;
+
+use Illuminate\Database\Eloquent\Model;
+
+class Person extends Model {}

tests/Rector/Class_/AddHasFactoryToModelsRectorConfigured/Fixture/skip_if_already_present.php.inc

@@ -0,0 +1,12 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfigured\Fixture;
+
+use Illuminate\Database\Eloquent\Model;
+
+class SkipIfAlreadyPresent extends Model
+{
+    use \Illuminate\Database\Eloquent\Factories\HasFactory;
+}
+
+?>

tests/Rector/Class_/AddHasFactoryToModelsRectorConfigured/config/configured_rule.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use RectorLaravel\Rector\Class_\AddHasFactoryToModelsRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../../../../../config/config.php');
+
+    $rectorConfig->ruleWithConfiguration(AddHasFactoryToModelsRector::class, [
+        'RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfigured\Fixture\User',
+        'RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfigured\Fixture\SkipIfAlreadyPresent',
+    ]);
+};