Skip to content

Fix type hinting depending on Eloquent or Query Builder instance #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeniJaho merged 3 commits into from
Apr 8, 2025
Merged

Fix type hinting depending on Eloquent or Query Builder instance #324

GeniJaho merged 3 commits into from
Apr 8, 2025

Conversation

@GeniJaho
Copy link
Collaborator

@GeniJaho GeniJaho commented Mar 27, 2025

Fixes #319.

  • Adds one more code sample to EloquentWhereTypeHintClosureParameterRector
  • If the builder instance is an Eloquent Model, the type hint will be \Illuminate\Contracts\Database\Eloquent\Builder
  • If the builder instance is a Query Builder, the type hint will be Illuminate\Contracts\Database\Query\Builder

@GeniJaho GeniJaho merged commit 79d3761 into main Apr 8, 2025
5 checks passed
@GeniJaho GeniJaho deleted the fix-eloquent-where-type-hint branch April 8, 2025 22:22
@brunogaspar brunogaspar mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterfox peterfox peterfox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] EloquentWhereTypeHintClosureParameterRector The example does not match the actual implementation

3 participants

@GeniJaho @peterfox