Skip to content

Remove MinutesToSecondsInCacheRector from Laravel 5.8 set #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeniJaho merged 2 commits into from
Apr 5, 2025
Merged

Remove MinutesToSecondsInCacheRector from Laravel 5.8 set #325

GeniJaho merged 2 commits into from
Apr 5, 2025

Conversation

@GeniJaho
Copy link
Collaborator

@GeniJaho GeniJaho commented Mar 31, 2025

Fixes #299.

  • This rule is not idempotent, and I'm not sure there's a way to make it so.
  • Removing it from the set list will make the rule harder to discover, but it will be less breaking on projects where the 'minutes to seconds' migration has already been done.

@GeniJaho GeniJaho merged commit 1785e16 into main Apr 5, 2025
5 checks passed
@GeniJaho GeniJaho deleted the remove-minutes-to-seconds-rule-from-laravel-set branch April 5, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterfox peterfox peterfox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MinutesToSecondsInCacheRector Rule is applied when the argument is already multiplied correctly

3 participants

@GeniJaho @peterfox