Stop overriding previous tags #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@brunogaspar if you're able to check this branch out and try it, that would be very useful. This should fix the issue you've been having. |
|
@peterfox That seems to do it, thank you 🙏 |
GeniJaho
approved these changes
Apr 22, 2025
Collaborator
|
There's a new warning that popped up in tests after the latest core Rector changes:
It might have been there all along and not related to changes in this PR though. |
Collaborator
Author
|
@GeniJaho I'm not getting that error but I'm getting others though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
Reported by @brunogaspar that the rule was working okay but would overwrite tags with a fully qualified name even when the tag was already correct.
This PR seeks to change the situation so if the tag exists, then it will not apply any changes.
Looking at this rule. There's a few changes that might be required when it comes to the pivot changes that were added in #316. I have a feeling relationships like MorphToMany haven't been considered and it should probably assign the Pivot class if the relationship uses one.