-
Notifications
You must be signed in to change notification settings - Fork 57
Description
Dear Dinh Nguyen Anh Dung,
I was your student of your "Introduction to Game Programming" course. I still have a bad impression of your initial code. It is a nightmare. If this code were reviewed in a code review session, it would be rejected after just looking it, and you would be criticized a lot by the project manager. I can't believe that this code is written by a teacher that having 20-year-experience of developing. Because with just a little basic knowledge of code cleaning, I would definitely never code like this. What a shame! Using linter, I discovered a lot of problems related to form. There are definitely a lot of problems related to content, such as meaningless variable names, overly complex functions, etc.
I strongly request you to refactor the project to increase readability and maintainability so that this course is no longer a nightmare for students. Because I surely you can't either add some features or maintain such mess like this. You can't expect students can refactor code or write code from scratch because simply the course title is "Introduction to Game Programming", not "Advanced game programming".
Here are all the issues that the linter detected in your project. You can also see them in *.csv file. There are 4493 warnings and 4634 messages in total. Some of the issues are duplicates because they come from different rules that target the same content but in different cases. You can simply understand that the more duplicates the issues are, the more serious they are.
Regards.
