Skip to content

Commit 705b606

Browse files
committed
Fix old code quality issues in regexp.py
- Replace alternation with character class in regex - Remove TODO comment (now a Note about ASCII-only support) - Merge implicit string concatenation
1 parent 396efa4 commit 705b606

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

gixy/core/regexp.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,19 @@ def _build_reverse_list(original):
2323
return frozenset(result)
2424

2525

26-
FIX_NAMED_GROUPS_RE = re.compile(r"(?<!\\)\(\?(?:<|')(\w+)(?:>|')")
26+
FIX_NAMED_GROUPS_RE = re.compile(r"(?<!\\)\(\?[<'](\w+)[>']")
2727

2828
CATEGORIES = {
29-
# TODO(buglloc): unicode?
29+
# Note: ASCII only, unicode not supported
3030
sre_parse.CATEGORY_SPACE: sre_parse.WHITESPACE,
3131
sre_parse.CATEGORY_NOT_SPACE: _build_reverse_list(sre_parse.WHITESPACE),
3232
sre_parse.CATEGORY_DIGIT: sre_parse.DIGITS,
3333
sre_parse.CATEGORY_NOT_DIGIT: _build_reverse_list(sre_parse.DIGITS),
3434
sre_parse.CATEGORY_WORD: frozenset(
35-
"abcdefghijklmnopqrstuvwxyz" "ABCDEFGHIJKLMNOPQRSTUVWXYZ" "0123456789_"
35+
"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_"
3636
),
3737
sre_parse.CATEGORY_NOT_WORD: _build_reverse_list(
38-
frozenset(
39-
"abcdefghijklmnopqrstuvwxyz" "ABCDEFGHIJKLMNOPQRSTUVWXYZ" "0123456789_"
40-
)
38+
frozenset("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_")
4139
),
4240
sre_parse.CATEGORY_LINEBREAK: frozenset("\n"),
4341
sre_parse.CATEGORY_NOT_LINEBREAK: _build_reverse_list(frozenset("\n")),

0 commit comments

Comments
 (0)