Skip to content

Commit 4dca682

Browse files
committed
minor tweaks
1 parent e4a9647 commit 4dca682

File tree

4 files changed

+16
-9
lines changed

4 files changed

+16
-9
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Type: Package
22
Package: parameters
33
Title: Processing of Model Parameters
4-
Version: 0.24.2.19
4+
Version: 0.24.2.20
55
Authors@R:
66
c(person(given = "Daniel",
77
family = "Lüdecke",

R/methods_BayesFactor.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ model_parameters.BFBayesFactor <- function(model,
245245

246246
#' @export
247247
p_value.BFBayesFactor <- function(model, ...) {
248-
p <- bayestestR::p_direction(model)
248+
p <- bayestestR::p_direction(model, ...)
249249
.data_frame(
250250
Parameter = .remove_backticks_from_string(p$Parameter),
251251
p = sapply(p$pd, bayestestR::convert_pd_to_p, simplify = TRUE)

R/methods_brms.R

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,13 +123,8 @@ model_parameters.brmsfit <- function(model,
123123
return(params)
124124
} else {
125125

126-
## TODO: remove this once insight > 1.2.0 is on CRAN
127-
if (utils::packageVersion("insight") > "1.2.0" && effects == "random") {
128-
if (group_level) {
129-
effects <- "grouplevel"
130-
} else {
131-
effects <- "random_variance"
132-
}
126+
if (utils::packageVersion("insight") > "1.2.0" && effects == "random" && group_level) {
127+
effects <- "grouplevel"
133128
}
134129

135130
# Processing
@@ -312,6 +307,9 @@ standard_error.brmsfit <- function(model,
312307
effects = "fixed",
313308
component = "all",
314309
...) {
310+
311+
## TODO: remove validation of effects and component once insight > 1.2.0 is on CRAN
312+
315313
effects <- insight::validate_argument(
316314
effects,
317315
c("fixed", "random")

R/methods_rstanarm.R

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ model_parameters.stanreg <- function(model,
2626
return(params)
2727
}
2828

29+
if (utils::packageVersion("insight") > "1.2.0" && effects == "random" && group_level) {
30+
effects <- "grouplevel"
31+
}
32+
2933
# Processing
3034
params <- .extract_parameters_bayesian(
3135
model,
@@ -47,6 +51,7 @@ model_parameters.stanreg <- function(model,
4751
...
4852
)
4953

54+
## TODO: remove this once insight > 1.2.0 on CRAN
5055
if (effects != "fixed") {
5156
random_effect_levels <- which(
5257
params$Effects == "random" & !startsWith(params$Parameter, "Sigma[")
@@ -99,6 +104,10 @@ model_parameters.stanmvreg <- function(model,
99104
drop = NULL,
100105
verbose = TRUE,
101106
...) {
107+
if (utils::packageVersion("insight") > "1.2.0" && effects == "random" && group_level) {
108+
effects <- "grouplevel"
109+
}
110+
102111
# Processing
103112
params <- .extract_parameters_bayesian(
104113
model,

0 commit comments

Comments
 (0)