Skip to content

Commit b529f66

Browse files
strengejackestrengejacke
committed
fix
1 parent d3157b5 commit b529f66

File tree

2 files changed

+144
-112
lines changed

2 files changed

+144
-112
lines changed

‎tests/testthat/_snaps/printing.md‎

Lines changed: 127 additions & 102 deletions
Original file line numberDiff line numberDiff line change
@@ -103,23 +103,23 @@
103103
# grouped parameters
104104

105105
Code
106-
print(out, groups = list(Engine = c("cyl6", "cyl8", "vs", "hp"), Interactions = c(
107-
"gear4:vs", "gear5:vs"), Controls = c(2, 3, 7)))
106+
print(out, groups = list(Engine = c(5, 6, 4, 1), Interactions = c(8, 9),
107+
Controls = c(2, 3, 7)))
108108
Output
109-
Parameter | Coefficient | SE | 95% CI | t(22) | p
110-
-----------------------------------------------------------------------
111-
Engine | | | | |
112-
cyl [6] | -2.47 | 2.21 | [ -7.05, 2.12] | -1.12 | 0.276
113-
cyl [8] | 1.97 | 5.11 | [ -8.63, 12.58] | 0.39 | 0.703
114-
vs | 3.18 | 3.79 | [ -4.68, 11.04] | 0.84 | 0.410
115-
hp | -0.06 | 0.02 | [ -0.11, -0.02] | -2.91 | 0.008
116-
Interactions | | | | |
117-
gear [4] * vs | -2.90 | 4.67 | [-12.57, 6.78] | -0.62 | 0.541
118-
gear [5] * vs | 2.59 | 4.54 | [ -6.82, 12.00] | 0.57 | 0.574
119-
Controls | | | | |
120-
gear [4] | 3.10 | 4.34 | [ -5.90, 12.10] | 0.71 | 0.482
121-
gear [5] | 4.80 | 3.48 | [ -2.42, 12.01] | 1.38 | 0.182
122-
drat | 2.70 | 2.03 | [ -1.52, 6.91] | 1.33 | 0.198
109+
Parameter | Coefficient | SE | 95% CI | t(22) | p
110+
----------------------------------------------------------------------
111+
Engine | | | | |
112+
cyl [6] | -2.47 | 2.21 | [ -7.05, 2.12] | -1.12 | 0.276
113+
cyl [8] | 1.97 | 5.11 | [ -8.63, 12.58] | 0.39 | 0.703
114+
vs | 3.18 | 3.79 | [ -4.68, 11.04] | 0.84 | 0.410
115+
hp | -0.06 | 0.02 | [ -0.11, -0.02] | -2.91 | 0.008
116+
Interactions | | | | |
117+
gear [4] * vs | -2.90 | 4.67 | [-12.57, 6.78] | -0.62 | 0.541
118+
gear [5] * vs | 2.59 | 4.54 | [ -6.82, 12.00] | 0.57 | 0.574
119+
Controls | | | | |
120+
gear [4] | 3.10 | 4.34 | [ -5.90, 12.10] | 0.71 | 0.482
121+
gear [5] | 4.80 | 3.48 | [ -2.42, 12.01] | 1.38 | 0.182
122+
drat | 2.70 | 2.03 | [ -1.52, 6.91] | 1.33 | 0.198
123123
Message
124124
125125
Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed
@@ -128,23 +128,48 @@
128128
---
129129

130130
Code
131-
print(out, sep = " ", groups = list(Engine = c("cyl6", "cyl8", "vs", "hp"),
132-
Interactions = c("gear4:vs", "gear5:vs"), Controls = c(2, 3, 7)))
131+
print(out, groups = list(Engine = c("cyl [6]", "cyl [8]", "vs", "hp"),
132+
Interactions = c("gear [4] * vs", "gear [5] * vs"), Controls = c(2, 3, 7)))
133133
Output
134-
Parameter Coefficient SE 95% CI t(22) p
135-
------------------------------------------------------------------
136-
Engine
137-
cyl [6] -2.47 2.21 [ -7.05, 2.12] -1.12 0.276
138-
cyl [8] 1.97 5.11 [ -8.63, 12.58] 0.39 0.703
139-
vs 3.18 3.79 [ -4.68, 11.04] 0.84 0.410
140-
hp -0.06 0.02 [ -0.11, -0.02] -2.91 0.008
141-
Interactions
142-
gear [4] * vs -2.90 4.67 [-12.57, 6.78] -0.62 0.541
143-
gear [5] * vs 2.59 4.54 [ -6.82, 12.00] 0.57 0.574
144-
Controls
145-
gear [4] 3.10 4.34 [ -5.90, 12.10] 0.71 0.482
146-
gear [5] 4.80 3.48 [ -2.42, 12.01] 1.38 0.182
147-
drat 2.70 2.03 [ -1.52, 6.91] 1.33 0.198
134+
Parameter | Coefficient | SE | 95% CI | t(22) | p
135+
----------------------------------------------------------------------
136+
Engine | | | | |
137+
cyl [6] | -2.47 | 2.21 | [ -7.05, 2.12] | -1.12 | 0.276
138+
cyl [8] | 1.97 | 5.11 | [ -8.63, 12.58] | 0.39 | 0.703
139+
vs | 3.18 | 3.79 | [ -4.68, 11.04] | 0.84 | 0.410
140+
hp | -0.06 | 0.02 | [ -0.11, -0.02] | -2.91 | 0.008
141+
Interactions | | | | |
142+
gear [4] * vs | -2.90 | 4.67 | [-12.57, 6.78] | -0.62 | 0.541
143+
gear [5] * vs | 2.59 | 4.54 | [ -6.82, 12.00] | 0.57 | 0.574
144+
Controls | | | | |
145+
gear [4] | 3.10 | 4.34 | [ -5.90, 12.10] | 0.71 | 0.482
146+
gear [5] | 4.80 | 3.48 | [ -2.42, 12.01] | 1.38 | 0.182
147+
drat | 2.70 | 2.03 | [ -1.52, 6.91] | 1.33 | 0.198
148+
Message
149+
150+
Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed
151+
using a Wald t-distribution approximation.
152+
153+
---
154+
155+
Code
156+
print(out, sep = " ", groups = list(Engine = c(5, 6, 4, 1), Interactions = c(8,
157+
9), Controls = c(2, 3, 7)))
158+
Output
159+
Parameter Coefficient SE 95% CI t(22) p
160+
-----------------------------------------------------------------
161+
Engine
162+
cyl [6] -2.47 2.21 [ -7.05, 2.12] -1.12 0.276
163+
cyl [8] 1.97 5.11 [ -8.63, 12.58] 0.39 0.703
164+
vs 3.18 3.79 [ -4.68, 11.04] 0.84 0.410
165+
hp -0.06 0.02 [ -0.11, -0.02] -2.91 0.008
166+
Interactions
167+
gear [4] * vs -2.90 4.67 [-12.57, 6.78] -0.62 0.541
168+
gear [5] * vs 2.59 4.54 [ -6.82, 12.00] 0.57 0.574
169+
Controls
170+
gear [4] 3.10 4.34 [ -5.90, 12.10] 0.71 0.482
171+
gear [5] 4.80 3.48 [ -2.42, 12.01] 1.38 0.182
172+
drat 2.70 2.03 [ -1.52, 6.91] 1.33 0.198
148173
Message
149174
150175
Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed
@@ -233,23 +258,23 @@
233258
# select pattern
234259

235260
Code
236-
print(out, groups = list(Engine = c("cyl6", "cyl8", "vs", "hp"), Interactions = c(
237-
"gear4:vs", "gear5:vs"), Controls = c(2, 3, 7)))
261+
print(out, groups = list(Engine = c(5, 6, 4, 1), Interactions = c(8, 9),
262+
Controls = c(2, 3, 7)))
238263
Output
239-
Parameter | Coefficient | SE | 95% CI | t(22) | p
240-
-----------------------------------------------------------------------
241-
Engine | | | | |
242-
cyl [6] | -2.47 | 2.21 | [ -7.05, 2.12] | -1.12 | 0.276
243-
cyl [8] | 1.97 | 5.11 | [ -8.63, 12.58] | 0.39 | 0.703
244-
vs | 3.18 | 3.79 | [ -4.68, 11.04] | 0.84 | 0.410
245-
hp | -0.06 | 0.02 | [ -0.11, -0.02] | -2.91 | 0.008
246-
Interactions | | | | |
247-
gear [4] * vs | -2.90 | 4.67 | [-12.57, 6.78] | -0.62 | 0.541
248-
gear [5] * vs | 2.59 | 4.54 | [ -6.82, 12.00] | 0.57 | 0.574
249-
Controls | | | | |
250-
gear [4] | 3.10 | 4.34 | [ -5.90, 12.10] | 0.71 | 0.482
251-
gear [5] | 4.80 | 3.48 | [ -2.42, 12.01] | 1.38 | 0.182
252-
drat | 2.70 | 2.03 | [ -1.52, 6.91] | 1.33 | 0.198
264+
Parameter | Coefficient | SE | 95% CI | t(22) | p
265+
----------------------------------------------------------------------
266+
Engine | | | | |
267+
cyl [6] | -2.47 | 2.21 | [ -7.05, 2.12] | -1.12 | 0.276
268+
cyl [8] | 1.97 | 5.11 | [ -8.63, 12.58] | 0.39 | 0.703
269+
vs | 3.18 | 3.79 | [ -4.68, 11.04] | 0.84 | 0.410
270+
hp | -0.06 | 0.02 | [ -0.11, -0.02] | -2.91 | 0.008
271+
Interactions | | | | |
272+
gear [4] * vs | -2.90 | 4.67 | [-12.57, 6.78] | -0.62 | 0.541
273+
gear [5] * vs | 2.59 | 4.54 | [ -6.82, 12.00] | 0.57 | 0.574
274+
Controls | | | | |
275+
gear [4] | 3.10 | 4.34 | [ -5.90, 12.10] | 0.71 | 0.482
276+
gear [5] | 4.80 | 3.48 | [ -2.42, 12.01] | 1.38 | 0.182
277+
drat | 2.70 | 2.03 | [ -1.52, 6.91] | 1.33 | 0.198
253278
Message
254279
255280
Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed
@@ -260,17 +285,17 @@
260285
Code
261286
print(out, select = "{coef} ({se})")
262287
Output
263-
Parameter | Estimate (SE)
264-
-----------------------------
265-
hp | -0.06 (0.02)
266-
gear [4] | 3.10 (4.34)
267-
gear [5] | 4.80 (3.48)
268-
vs | 3.18 (3.79)
269-
cyl [6] | -2.47 (2.21)
270-
cyl [8] | 1.97 (5.11)
271-
drat | 2.70 (2.03)
272-
gear [4] * vs | -2.90 (4.67)
273-
gear [5] * vs | 2.59 (4.54)
288+
Parameter | Coefficient (SE)
289+
--------------------------------
290+
hp | -0.06 (0.02)
291+
gear [4] | 3.10 (4.34)
292+
gear [5] | 4.80 (3.48)
293+
vs | 3.18 (3.79)
294+
cyl [6] | -2.47 (2.21)
295+
cyl [8] | 1.97 (5.11)
296+
drat | 2.70 (2.03)
297+
gear [4] * vs | -2.90 (4.67)
298+
gear [5] * vs | 2.59 (4.54)
274299
Message
275300
276301
Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed
@@ -281,17 +306,17 @@
281306
Code
282307
print(out, select = "{coef}{stars}|[{ci}]")
283308
Output
284-
Parameter | Estimate | [ci]
285-
------------------------------------------
286-
hp | -0.06** | [ -0.11, -0.02]
287-
gear [4] | 3.10 | [ -5.90, 12.10]
288-
gear [5] | 4.80 | [ -2.42, 12.01]
289-
vs | 3.18 | [ -4.68, 11.04]
290-
cyl [6] | -2.47 | [ -7.05, 2.12]
291-
cyl [8] | 1.97 | [ -8.63, 12.58]
292-
drat | 2.70 | [ -1.52, 6.91]
293-
gear [4] * vs | -2.90 | [-12.57, 6.78]
294-
gear [5] * vs | 2.59 | [ -6.82, 12.00]
309+
Parameter | Coefficient | [CI]
310+
---------------------------------------------
311+
hp | -0.06** | [ -0.11, -0.02]
312+
gear [4] | 3.10 | [ -5.90, 12.10]
313+
gear [5] | 4.80 | [ -2.42, 12.01]
314+
vs | 3.18 | [ -4.68, 11.04]
315+
cyl [6] | -2.47 | [ -7.05, 2.12]
316+
cyl [8] | 1.97 | [ -8.63, 12.58]
317+
drat | 2.70 | [ -1.52, 6.91]
318+
gear [4] * vs | -2.90 | [-12.57, 6.78]
319+
gear [5] * vs | 2.59 | [ -6.82, 12.00]
295320
Message
296321
297322
Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed
@@ -300,23 +325,23 @@
300325
---
301326

302327
Code
303-
print(out, groups = list(Engine = c("cyl6", "cyl8", "vs", "hp"), Interactions = c(
304-
"gear4:vs", "gear5:vs"), Controls = c(2, 3, 7)), select = "{coef}{stars}|[{ci}]")
328+
print(out, groups = list(Engine = c(5, 6, 4, 1), Interactions = c(8, 9),
329+
Controls = c(2, 3, 7)), select = "{coef}{stars}|[{ci}]")
305330
Output
306-
Parameter | Estimate | [ci]
307-
---------------------------------------------
308-
Engine | |
309-
cyl [6] | -2.47 | [ -7.05, 2.12]
310-
cyl [8] | 1.97 | [ -8.63, 12.58]
311-
vs | 3.18 | [ -4.68, 11.04]
312-
hp | -0.06** | [ -0.11, -0.02]
313-
Interactions | |
314-
gear [4] * vs | -2.90 | [-12.57, 6.78]
315-
gear [5] * vs | 2.59 | [ -6.82, 12.00]
316-
Controls | |
317-
gear [4] | 3.10 | [ -5.90, 12.10]
318-
gear [5] | 4.80 | [ -2.42, 12.01]
319-
drat | 2.70 | [ -1.52, 6.91]
331+
Parameter | Coefficient | [CI]
332+
-----------------------------------------------
333+
Engine | |
334+
cyl [6] | -2.47 | [ -7.05, 2.12]
335+
cyl [8] | 1.97 | [ -8.63, 12.58]
336+
vs | 3.18 | [ -4.68, 11.04]
337+
hp | -0.06** | [ -0.11, -0.02]
338+
Interactions | |
339+
gear [4] * vs | -2.90 | [-12.57, 6.78]
340+
gear [5] * vs | 2.59 | [ -6.82, 12.00]
341+
Controls | |
342+
gear [4] | 3.10 | [ -5.90, 12.10]
343+
gear [5] | 4.80 | [ -2.42, 12.01]
344+
drat | 2.70 | [ -1.52, 6.91]
320345
Message
321346
322347
Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed
@@ -325,23 +350,23 @@
325350
---
326351

327352
Code
328-
print(out, sep = " ", groups = list(Engine = c("cyl6", "cyl8", "vs", "hp"),
329-
Interactions = c("gear4:vs", "gear5:vs"), Controls = c(2, 3, 7)), select = "{coef}{stars}|[{ci}]")
353+
print(out, sep = " ", groups = list(Engine = c(5, 6, 4, 1), Interactions = c(8,
354+
9), Controls = c(2, 3, 7)), select = "{coef}{stars}|[{ci}]")
330355
Output
331-
Parameter Estimate [ci]
332-
-------------------------------------------
333-
Engine
334-
cyl [6] -2.47 [ -7.05, 2.12]
335-
cyl [8] 1.97 [ -8.63, 12.58]
336-
vs 3.18 [ -4.68, 11.04]
337-
hp -0.06** [ -0.11, -0.02]
338-
Interactions
339-
gear [4] * vs -2.90 [-12.57, 6.78]
340-
gear [5] * vs 2.59 [ -6.82, 12.00]
341-
Controls
342-
gear [4] 3.10 [ -5.90, 12.10]
343-
gear [5] 4.80 [ -2.42, 12.01]
344-
drat 2.70 [ -1.52, 6.91]
356+
Parameter Coefficient [CI]
357+
---------------------------------------------
358+
Engine
359+
cyl [6] -2.47 [ -7.05, 2.12]
360+
cyl [8] 1.97 [ -8.63, 12.58]
361+
vs 3.18 [ -4.68, 11.04]
362+
hp -0.06** [ -0.11, -0.02]
363+
Interactions
364+
gear [4] * vs -2.90 [-12.57, 6.78]
365+
gear [5] * vs 2.59 [ -6.82, 12.00]
366+
Controls
367+
gear [4] 3.10 [ -5.90, 12.10]
368+
gear [5] 4.80 [ -2.42, 12.01]
369+
drat 2.70 [ -1.52, 6.91]
345370
Message
346371
347372
Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed

‎tests/testthat/test-printing.R‎

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,24 @@ withr::with_options(
3939
out <- model_parameters(model, drop = "^\\(Intercept")
4040
expect_snapshot(
4141
print(out, groups = list(
42-
Engine = c("cyl6", "cyl8", "vs", "hp"),
43-
Interactions = c("gear4:vs", "gear5:vs"),
42+
Engine = c(5, 6, 4, 1), # c("cyl6", "cyl8", "vs", "hp"),
43+
Interactions = c(8, 9), # c("gear4:vs", "gear5:vs"),
44+
Controls = c(2, 3, 7)
45+
))
46+
)
47+
expect_snapshot(
48+
print(out, groups = list(
49+
Engine = c("cyl [6]", "cyl [8]", "vs", "hp"),
50+
Interactions = c("gear [4] * vs", "gear [5] * vs"),
4451
Controls = c(2, 3, 7)
4552
))
4653
)
4754
expect_snapshot(
4855
print(out,
4956
sep = " ",
5057
groups = list(
51-
Engine = c("cyl6", "cyl8", "vs", "hp"),
52-
Interactions = c("gear4:vs", "gear5:vs"),
58+
Engine = c(5, 6, 4, 1),
59+
Interactions = c(8, 9),
5360
Controls = c(2, 3, 7)
5461
)
5562
)
@@ -80,26 +87,26 @@ withr::with_options(
8087
out <- model_parameters(model, drop = "^\\(Intercept")
8188
expect_snapshot(
8289
print(out, groups = list(
83-
Engine = c("cyl6", "cyl8", "vs", "hp"),
84-
Interactions = c("gear4:vs", "gear5:vs"),
90+
Engine = c(5, 6, 4, 1),
91+
Interactions = c(8, 9),
8592
Controls = c(2, 3, 7)
8693
))
8794
)
8895
expect_snapshot(print(out, select = "{coef} ({se})"))
8996
expect_snapshot(print(out, select = "{coef}{stars}|[{ci}]"))
9097
expect_snapshot(
9198
print(out, groups = list(
92-
Engine = c("cyl6", "cyl8", "vs", "hp"),
93-
Interactions = c("gear4:vs", "gear5:vs"),
99+
Engine = c(5, 6, 4, 1),
100+
Interactions = c(8, 9),
94101
Controls = c(2, 3, 7)
95102
), select = "{coef}{stars}|[{ci}]")
96103
)
97104
expect_snapshot(
98105
print(out,
99106
sep = " ",
100107
groups = list(
101-
Engine = c("cyl6", "cyl8", "vs", "hp"),
102-
Interactions = c("gear4:vs", "gear5:vs"),
108+
Engine = c(5, 6, 4, 1),
109+
Interactions = c(8, 9),
103110
Controls = c(2, 3, 7)
104111
),
105112
select = "{coef}{stars}|[{ci}]"

0 commit comments

Comments
 (0)