fix

Author: strengejacke

R/format.R

@@ -116,14 +116,6 @@ format.parameters_model <- function(x,
     x <- .format_ranef_parameters(x)
   }
 
-  # group parameters - this function find those parameters that should be
-  # grouped, reorders parameters into groups and indents lines that belong
-  # to one group, adding a header for each group
-  if (!is.null(groups)) {
-    x <- .parameter_groups(x, groups)
-  }
-  indent_rows <- attributes(x)$indent_rows
-
   # prepare output, to have in shape for printing. this function removes
   # empty columns, or selects only those columns that should be printed
   x <- .prepare_x_for_print(x, select, coef_name, s_value)
@@ -210,7 +202,7 @@ format.parameters_model <- function(x,
   }
 
   # information about indention / row groups
-  attr(formatted_table, "indent_rows") <- indent_rows
+  attr(formatted_table, "indent_rows") <- groups
 
   # vertical layout possible, if these have just one row
   if (identical(list(...)$layout, "vertical")) {
@@ -394,13 +386,6 @@ format.compare_parameters <- function(x,
     out <- datawizard::data_arrange(out, c("Effects", "Component"))
   }
 
-  # group parameters - this function find those parameters that should be
-  # grouped, reorders parameters into groups and indents lines that belong
-  # to one group, adding a header for each group
-  if (!is.null(groups) && !identical(engine, "tt")) {
-    out <- .parameter_groups(out, groups)
-  }
-
   # check whether to split table by certain factors/columns (like component, response...)
   split_by <- split_column <- .prepare_splitby_for_print(x)
 
@@ -462,6 +447,9 @@ format.compare_parameters <- function(x,
     formatted_table <- .add_obs_row(formatted_table, parameters_attributes, style = select)
   }
 
+  # information about indention / row groups
+  attr(formatted_table, "indent_rows") <- groups
+
   formatted_table
 }
 

R/utils_format.R

@@ -767,100 +767,6 @@
 }
 
 
-# helper grouping parameters -------------------
-
-
-.parameter_groups <- function(x, groups) {
-  # only apply to conditional component for now
-  if ("Component" %in% colnames(x) && !any(x$Component == "conditional")) {
-    return(x)
-  }
-  if ("Component" %in% colnames(x)) {
-    row_index <- which(x$Component == "conditional")
-  } else {
-    row_index <- seq_len(nrow(x))
-  }
-
-  x_other <- x[-row_index, ]
-  x <- x[row_index, ]
-
-  att <- attributes(x)
-  indent_rows <- NULL
-  indent_parameters <- NULL
-
-  if (is.list(groups)) {
-    # find parameter names and replace by rowindex
-    group_rows <- lapply(groups, function(i) {
-      if (is.character(i)) {
-        i <- match(i, x$Parameter)
-      }
-      i
-    })
-
-    # validation check - check if all parameter names in the
-    # group list are spelled correctly
-    misspelled <- vapply(group_rows, anyNA, TRUE)
-
-    if (any(misspelled)) {
-      # remove invalid groups
-      group_rows[misspelled] <- NULL
-      # tell user
-      insight::format_alert(
-        "Couldn't find one or more parameters specified in following groups:",
-        toString(names(misspelled[misspelled])),
-        "Maybe you misspelled parameter names?"
-      )
-    }
-
-
-    # sort parameters according to grouping
-    selected_rows <- unlist(group_rows)
-    indent_parameters <- x$Parameter[selected_rows]
-    x <- rbind(x[selected_rows, ], x[-selected_rows, ])
-
-    # set back correct indices
-    groups <- 1
-    for (i in 2:length(group_rows)) {
-      groups <- c(groups, groups[i - 1] + length(group_rows[[i - 1]]))
-    }
-    names(groups) <- names(group_rows)
-  } else {
-    # find parameter names and replace by rowindex
-    group_names <- names(groups)
-    groups <- match(groups, x$Parameter)
-    names(groups) <- group_names
-
-    # order groups
-    groups <- sort(groups, na.last = TRUE)
-  }
-
-
-  empty_row <- x[1, ]
-  for (i in seq_len(ncol(empty_row))) {
-    empty_row[[i]] <- NA
-  }
-
-  for (i in rev(seq_along(groups))) {
-    x[seq(groups[i] + 1, nrow(x) + 1), ] <- x[seq(groups[i], nrow(x)), ]
-    x[groups[i], ] <- empty_row
-  }
-
-  # find row indices of indented parameters
-  if (!is.null(indent_parameters)) {
-    indent_rows <- match(indent_parameters, x$Parameter)
-  }
-
-  # add other rows back
-  if (nrow(x_other) > 0) {
-    x <- rbind(x, x_other)
-  }
-
-  attributes(x) <- utils::modifyList(att, attributes(x))
-  attr(x, "indent_rows") <- indent_rows
-  x
-}
-
-
 # .insert_row <- function(x, newrow, r) {
 #   existingDF[seq(r+1,nrow(existingDF)+1),] <- existingDF[seq(r,nrow(existingDF)),]
 #   existingDF[r,] <- newrow