Skip to content

Commit d13e1da

Browse files
committed
fix #1178
1 parent 0c20d19 commit d13e1da

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Type: Package
22
Package: parameters
33
Title: Processing of Model Parameters
4-
Version: 0.28.2.9
4+
Version: 0.28.2.10
55
Authors@R:
66
c(person(given = "Daniel",
77
family = "Lüdecke",

NEWS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# parameters (devel)
22

3+
* fixed bug in `standardize_info(<fixest>)` that was preventing
4+
`standardise_parameters()` from working for `fixest` models.
5+
36
* `equivalence_test()` gets methods for objects from the *modelbased* package.
47

58
* Improved support for objects from package *survey*.

R/standardize_info.R

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ standardize_info.default <- function(model,
5050
insight::find_parameters(model, effects = "fixed", flatten = TRUE, ...)
5151
}
5252
types <- parameters_type(model)
53-
# model_matrix <- as.data.frame(stats::model.matrix(model))
5453
model_matrix <- as.data.frame(insight::get_modelmatrix(model))
5554
model_data <- insight::get_data(model, source = "mf", verbose = FALSE)
5655
wgts <- insight::get_weights(model, remove_na = TRUE)
@@ -321,11 +320,8 @@ standardize_info.default <- function(model,
321320
#' @keywords internal
322321
.std_info_response_smart <- function(model, info, data, model_matrix, types, robust = FALSE, w = NULL, ...) {
323322
if (info$is_linear) {
324-
if (inherits(model, c("gls", "lme"))) {
325-
response <- insight::get_response(model)
326-
} else {
327-
response <- stats::model.frame(model)[[1]]
328-
}
323+
response <- insight::get_response(model)
324+
329325
means <- deviations <- rep(NA_real_, length = length(names(model_matrix)))
330326
for (i in seq_along(names(model_matrix))) {
331327
variable <- names(model_matrix)[i]
@@ -365,11 +361,7 @@ standardize_info.default <- function(model,
365361

366362
#' @keywords internal
367363
.std_info_response_basic <- function(model, info, params, robust = FALSE, w = NULL, ...) {
368-
if (inherits(model, c("gls", "lme"))) {
369-
response <- insight::get_response(model)
370-
} else {
371-
response <- stats::model.frame(model)[[1]]
372-
}
364+
response <- insight::get_response(model)
373365

374366
if (info$is_linear) {
375367
if (robust) {

0 commit comments

Comments
 (0)