-
Notifications
You must be signed in to change notification settings - Fork 14
Description
The test single_local_two_remote_authorities_same_remote_transport is broken but we dont how.
The mock uTransport (utransport-foo) is probably the reason. The register_listener() method accepts the source_filter as input (because it has to...) but does nothing with it.
The test was passing with a broken version because the streamer somehow forwarded messages based only on the in-transport but not the in-authority. As a consequence messages from both "remote" authorities in the test were being forwarded even though only one UListener was created.
Issue #71 points to the actual underlying flaw in the streamer lib. Unfortunately for now fixing this issue causes the test to fail. In short: it should have NOT worked before the fix and should work now but it does the exact opposite.
The currently adopted solution to this conundrum is to just ignore the broken test away and worry about the test later.
Manual testing has sufficiently convinced us that the new version is actually working.