Bugfix: more rigorous forwarding listener cache #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(not just in-transport and out-authority as before)
Benedikt-Illich
force-pushed
the
bugfix-weak-forwarder-cache-identification
branch
from
34797a6 to
404e963
Compare
PLeVasseur
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Previously forwarders were cached based on in-transport and out-authority, which fails to recognize multiple in-authorities on a single transport.
To fix this issue, the cache is now based on the tuple (in-transport: UTransport, in-authority: String, out-authority: String) which clears up any ambiguity.