Update secrets.go #195
Open
Update secrets.go #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limits regex to 20 chars (prefix + 16) (\b) to improve and not grep big strings ( false positive )
edoardottt
reviewed
Jul 8, 2025
Owner
edoardottt
left a comment
edoardottt
left a comment
There was a problem hiding this comment.
Thanks for your contribution @incogbyte , really appreciated. A comment reasoning about proposed changes.
| "AWS Access Key", | ||
| "AWS Access Key", | ||
| *regexp.MustCompile(`(A3T[A-Z0-9]|AKIA|ACCA|AGPA|AIDA|AROA|AIPA|ANPA|ANVA|ASIA|ASCA|APKA)[A-Z0-9]{16}`), | ||
| *regexp.MustCompile(`\b(A3T[A-Z0-9]|AKIA|ACCA|AGPA|AIDA|AROA|AIPA|ANPA|ANVA|ASIA|ASCA|APKA)[A-Z0-9]{16}\b`), |
Owner
There was a problem hiding this comment.
I'm not sure it would be an improvement... I mean yes on avoiding the false positives, but then for example if there is something like fooAKIAEXAMPLEKEY1234bar it won't be noticed. Could be also in a minified JS script.
| "AWS MWS Key", | ||
| "AWS MWS Key", | ||
| *regexp.MustCompile(`amzn\.mws\.[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}`), | ||
| *regexp.MustCompile(`\bamzn\.mws\.[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\b`), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits regex to 20 chars (prefix + 16)
(\b) to improve and not grep big strings ( false positive )