Skip to content

Commit 824edfe

Browse files
committed
Add OSGi condition which is satisfied once the default Ehcache services
are registered This allows to defer starting of custom OSGi DS component which rely on the EhcacheManager in their activate() method until the Ehcache services are registered This closes #3232
1 parent 561af43 commit 824edfe

File tree

3 files changed

+77
-1
lines changed

3 files changed

+77
-1
lines changed

docs/src/docs/asciidoc/user/osgi.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ Additional features can then be added by including one or more of:
5353
* `org.ehcache:ehcache-clustered`
5454
* `org.ehcache:ehcache-transactions`
5555

56+
In order to defer starting OSGi DS components which leverage `org.ehcache.core.CacheManager` (for example via `CacheManagerBuilder`) or `javax.cache.spi.CachingProvider` (for example via `javax.cache.Caching`) until all relevant services for Ehcache are available one can leverage the https://docs.osgi.org/specification/osgi.core/8.0.0/service.condition.html[OSGi condition] with id `ehcache`.
57+
5658
=== Reverting to JDK Service Lookup
5759

5860
If the `org.ehcache.core.osgi` property is set to `"false"` as either a framework or system property then Ehcache will

ehcache-impl/build.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ dependencies {
5454
implementation group: 'org.ehcache', name: 'sizeof', version: parent.sizeofVersion
5555
implementation group: 'org.terracotta', name: 'terracotta-utilities-tools', version: parent.terracottaUtilitiesVersion
5656
compileOnly 'org.osgi:org.osgi.service.component.annotations:1.3.0'
57+
compileOnly 'org.osgi:org.osgi.service.component:1.3.0'
58+
implementation 'org.osgi:org.osgi.service.condition:1.0.0'
5759
testImplementation project(':core-spi-test')
5860
testImplementation 'org.ow2.asm:asm:6.2'
5961
testImplementation 'org.ow2.asm:asm-commons:6.2'
@@ -65,7 +67,7 @@ jar {
6567
bnd (
6668
'Export-Package': '!org.ehcache.impl.internal.*, org.ehcache.impl.*, org.ehcache.config.builders, ' +
6769
'org.ehcache.impl.internal.spi.loaderwriter', //ugly 107 induced internal export wart
68-
'Import-Package': '!sun.misc, !javax.annotation, *',
70+
'Import-Package': '!sun.misc, !javax.annotation, org.osgi.service.condition;resolution:=optional, *',
6971
)
7072
}
7173

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
/*
2+
* Copyright Terracotta, Inc.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
package org.ehcache.impl.osgi;
17+
18+
import org.ehcache.core.EhcacheManager;
19+
import org.ehcache.core.events.CacheEventDispatcherFactory;
20+
import org.ehcache.core.events.CacheEventListenerProvider;
21+
import org.ehcache.core.spi.service.ServiceFactory;
22+
import org.ehcache.core.spi.store.Store;
23+
import org.ehcache.impl.internal.spi.resilience.DefaultResilienceStrategyProvider;
24+
import org.ehcache.impl.internal.store.tiering.TieredStore;
25+
import org.ehcache.impl.internal.store.tiering.TieredStoreProviderFactory;
26+
import org.ehcache.spi.loaderwriter.CacheLoaderWriterProvider;
27+
import org.ehcache.spi.loaderwriter.WriteBehindProvider;
28+
import org.ehcache.spi.resilience.ResilienceStrategyProvider;
29+
import org.ehcache.spi.serialization.SerializationProvider;
30+
import org.osgi.service.component.ComponentConstants;
31+
import org.osgi.service.component.annotations.Component;
32+
import org.osgi.service.component.annotations.Reference;
33+
import org.osgi.service.condition.Condition;
34+
35+
/**
36+
* The condition is satisfied once all default {@link ServiceFactory} objects mentioned in {@link EhcacheManager} are registered.
37+
* Those are
38+
* <ol>
39+
* <li>{@link Store.Provider} provided through DS component {@link TieredStoreProviderFactory}</li>
40+
* <li>{@link CacheLoaderWriterProvider} provided through DS component {@link DefaultCacheLoaderWriterProviderFactory}</li>
41+
* <li>{@link WriteBehindProvider} provided through DS component {@link WriteBehindProviderFactory}</li>
42+
* <li>{@link CacheEventDispatcherFactory} provided through DS component {@link CacheEventNotificationListenerServiceProviderFactory}</li>
43+
* <li>{@link CacheEventListenerProvider} provided through DS component {@link DefaultCacheEventListenerProviderFactory}</li>
44+
* <li>{@link ResilienceStrategyProvider} provided through DS component {@link DefaultResilienceStrategyProvider}</li>
45+
* <li>{@link SerializationProvider} provided through DS component {@link DefaultSerializationProviderFactory}, used in {@link EhcacheCachingProvider}</li>
46+
* </ol>
47+
* Because those services are not provided directly but through {@link ServiceFactory} this condition references directly the responsible default factories (via their component name)
48+
*/
49+
@Component(property = Condition.CONDITION_ID + "=ehcache")
50+
public class EhcacheReadyCondition implements Condition {
51+
52+
@Reference(target = "("+ComponentConstants.COMPONENT_NAME+"=org.ehcache.impl.internal.store.tiering.TieredStoreProviderFactory)")
53+
private ServiceFactory<TieredStore.Provider> storeProviderFactory;
54+
55+
@Reference(target = "("+ComponentConstants.COMPONENT_NAME+"=org.ehcache.impl.internal.spi.loaderwriter.DefaultCacheLoaderWriterProviderFactory)")
56+
private ServiceFactory<CacheLoaderWriterProvider> cacheLoaderWriterProviderFactory;
57+
58+
@Reference(target = "("+ComponentConstants.COMPONENT_NAME+"=org.ehcache.impl.internal.loaderwriter.writebehind.WriteBehindProviderFactory)")
59+
private ServiceFactory<WriteBehindProvider> writeBehindProviderFactory;
60+
61+
@Reference(target = "("+ComponentConstants.COMPONENT_NAME+"=org.ehcache.impl.internal.events.CacheEventNotificationListenerServiceProviderFactory)")
62+
private ServiceFactory<CacheEventDispatcherFactory> cacheEventNotificationListenerServiceProviderFactory;
63+
64+
@Reference(target = "("+ComponentConstants.COMPONENT_NAME+"=org.ehcache.impl.internal.spi.event.DefaultCacheEventListenerProviderFactory)")
65+
private ServiceFactory<CacheEventListenerProvider> cacheEventListenerProviderFactory;
66+
67+
@Reference(target = "("+ComponentConstants.COMPONENT_NAME+"=org.ehcache.impl.internal.spi.resilience.DefaultResilienceStrategyProviderFactory)")
68+
private ServiceFactory<ResilienceStrategyProvider> resilienceStrategyProviderFactory;
69+
70+
@Reference(target = "("+ComponentConstants.COMPONENT_NAME+"=org.ehcache.impl.internal.spi.serialization.DefaultSerializationProviderFactory)")
71+
private ServiceFactory<SerializationProvider> serializationProviderFactory;
72+
}

0 commit comments

Comments
 (0)