Skip to content

Commit 59bed8e

Browse files
authored
fix(system.security) revert removal of winlog.event_data fields (#14756)
Revert the preserve_duplicate_custom_fields change from #14756 because it causes unintended breaking changes to existing installations by removing winlog.event_data fields that previously existed by default. As a secondary effect, this leads to false positives in some detection rules that use those fields as exclusions.
1 parent 93ea23e commit 59bed8e

File tree

148 files changed

+6
-612
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

148 files changed

+6
-612
lines changed

packages/system/changelog.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# newer versions go on top
2+
- version: "2.5.2"
3+
changes:
4+
- description: Reverts removal of winlog.event_data fields used in detection rules.
5+
type: bugfix
6+
link: https://github.com/elastic/integrations/pull/14756
27
- version: "2.5.1"
38
changes:
49
- description: Fix condition in handlebar file of security data stream.

packages/system/data_stream/security/_dev/test/pipeline/test-1100.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@
3434
},
3535
"level": "information"
3636
},
37-
"tags": [
38-
"preserve_duplicate_custom_fields"
39-
],
4037
"winlog": {
4138
"channel": "Security",
4239
"computer_name": "WIN-41OB2LO92CR.wlbeat.local",

packages/system/data_stream/security/_dev/test/pipeline/test-1102.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@
4040
"Administrator"
4141
]
4242
},
43-
"tags": [
44-
"preserve_duplicate_custom_fields"
45-
],
4643
"user": {
4744
"domain": "WLBEAT",
4845
"id": "S-1-5-21-101361758-2486510592-3018839910-500",

packages/system/data_stream/security/_dev/test/pipeline/test-1104.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@
3434
},
3535
"level": "error"
3636
},
37-
"tags": [
38-
"preserve_duplicate_custom_fields"
39-
],
4037
"winlog": {
4138
"channel": "Security",
4239
"computer_name": "WIN-41OB2LO92CR.wlbeat.local",

packages/system/data_stream/security/_dev/test/pipeline/test-1105.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@
3434
},
3535
"level": "information"
3636
},
37-
"tags": [
38-
"preserve_duplicate_custom_fields"
39-
],
4037
"winlog": {
4138
"channel": "Security",
4239
"computer_name": "WIN-41OB2LO92CR.wlbeat.local",

packages/system/data_stream/security/_dev/test/pipeline/test-4627.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@
4141
"SERVER2$"
4242
]
4343
},
44-
"tags": [
45-
"preserve_duplicate_custom_fields"
46-
],
4744
"user": {
4845
"domain": "TEST1.LOCAL",
4946
"effective": {

packages/system/data_stream/security/_dev/test/pipeline/test-4658.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@
4242
"SERVER2$"
4343
]
4444
},
45-
"tags": [
46-
"preserve_duplicate_custom_fields"
47-
],
4845
"user": {
4946
"domain": "TEST1",
5047
"id": "S-1-5-20",

packages/system/data_stream/security/_dev/test/pipeline/test-4659.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@
4343
"administrator"
4444
]
4545
},
46-
"tags": [
47-
"preserve_duplicate_custom_fields"
48-
],
4946
"user": {
5047
"domain": "TEST1",
5148
"id": "S-1-5-21-1280187532-2219128962-763009249-500",

packages/system/data_stream/security/_dev/test/pipeline/test-4660.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@
4242
"administrator"
4343
]
4444
},
45-
"tags": [
46-
"preserve_duplicate_custom_fields"
47-
],
4845
"user": {
4946
"domain": "TEST1",
5047
"id": "S-1-5-21-1280187532-2219128962-763009249-500",

packages/system/data_stream/security/_dev/test/pipeline/test-4662.json-expected.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@
3131
"dadmin"
3232
]
3333
},
34-
"tags": [
35-
"preserve_duplicate_custom_fields"
36-
],
3734
"user": {
3835
"domain": "CONTOSO",
3936
"id": "S-1-5-21-3457937927-2839227994-823803824-1104",

0 commit comments

Comments
 (0)