Skip to content

Conversation

@giorgi-imerlishvili-elastic
Copy link
Contributor

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic commented Sep 28, 2025

Proposed commit message

Enhancement: Add dashboard for log categories Application Logs, Audit Logs, Console Logs, HTTP Logs, IPsec Audit Logs and Platform Logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

screencapture-127-0-0-1-5601-app-dashboards-2025-10-30-16_10_09

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic added the enhancement New feature or request label Sep 28, 2025
@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:azure_app_service Azure App Service labels Sep 29, 2025
make one dashboard which contains all information
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic changed the title Add dashboards for log categories Application Logs, Audit Logs, Console Logs, HTTP Logs, IPsec Audit Logs and Platform Logs. Add dashboard for log categories Application Logs, Audit Logs, Console Logs, HTTP Logs, IPsec Audit Logs and Platform Logs. Oct 1, 2025
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic changed the title Add dashboard for log categories Application Logs, Audit Logs, Console Logs, HTTP Logs, IPsec Audit Logs and Platform Logs. New dashboard and bug fixes Oct 3, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 4, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic changed the title New dashboard and bug fixes [Azure App Service] New dashboard and bug fixes Oct 5, 2025
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic marked this pull request as ready for review October 5, 2025 13:17
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic requested a review from a team as a code owner October 5, 2025 13:17
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic added the bugfix Pull request that fixes a bug issue label Oct 5, 2025
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Oct 6, 2025
version: "0.10.0"
source:
license: "Elastic-2.0"
description: "Collect logs from Azure App Service with Elastic Agent."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the screenshots attribute in the manifest file and include references to the dashboard image, similar to how it's done in other integrations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please make sure screenshots contain the whole dashboard, and also please add those same screenshots to the PR page (right now the screenshot in the PR description is truncated)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -1,4 +1,19 @@
# newer versions go on top
- version: "0.10.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having multiple changelog entries for the same PR, you can consolidate them into a single entry with a combined description.
example for reference:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to have in one change log as well. I like combined description idea, but what about type it can only have enhancement or bugfix value as I know. This PR contains enhancement and also bugfixes...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be hard to split the changes into 2 separate PRs? or even 3 as I see 3 changelogs?

Is it OK to have several changelogs in one PR @ishleenk17 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giorgi-imerlishvili-elastic - Could we create a separate PR for the ingest pipeline changes? Since we're adding a new dashboard to the integrations, it would be better to keep these changes distinct.

Copy link
Contributor Author

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed bugfixes from this PR and created new one: #15591

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic changed the title [Azure App Service] New dashboard and bug fixes [Azure App Service] New dashboard Oct 7, 2025
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic removed the bugfix Pull request that fixes a bug issue label Oct 7, 2025
@giorgi-imerlishvili-elastic
Copy link
Contributor Author

Removed log level panels from IPSecAudit and Audit logs section and updated screenshots

Any ideas, what else information/panel can be added instead of those? @lucian-ioan @muthu-mps

@muthu-mps
Copy link
Contributor

Can we update the dashboard image with real time log data. The current one shows 0 in all the panels.

@lucian-ioan
Copy link
Contributor

lucian-ioan commented Oct 16, 2025

Yeah I confirm, just double checked and IPSecAuditLogs and AuditLogs doesn't have log level field 😕, I'll remove panels for those.

I believe it's also the case for AppServiceHTTPLogs.

Any ideas, what else information/panel can be added instead of those? @lucian-ioan @muthu-mps

The goal is to try to provide value for the users. For example for the ones without Log Level:

  1. IpSecAuditLogs -> Fields: client_ip and result. Result can only be "Allowed" or "Denied". Top IPs denied would help understand which IPs keep trying to gain access without authorization.

  2. AppServiceAuditLogs -> Fields: user and protocol. Top Active Users and Top Protocol which tells the most popular auth methods (ex. SSH, OAuth2)

  3. AppServiceHTTPLogs -> Fields: sc_status = HTTP response code, time_taken = latency, cs_uri_stem = endpoint. Very useful fields here, starting from Average Latency, Status Codes Pie Chart, Top Endpoints Used all the way to aggregations such as highest average latency by endpoint.

Copy link
Contributor

@Linu-Elias Linu-Elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please dismiss the message at the top and then capture the screenshot.
  2. It should be "Total Errors" instead of "Total errors" so that the titles are consistent.
  3. Refer to this Observability integrations dashboards best practices to see if we missed anything.

@giorgi-imerlishvili-elastic
Copy link
Contributor Author

All feedbacks were addressed please review and let me know if I missed something @lucian-ioan, @muthu-mps, @Linu-Elias

@muthu-mps
Copy link
Contributor

@daniela-elastic - Can you take a look into the dashboard changes?

Copy link
Contributor

@lucian-ioan lucian-ioan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I'd rename any "Top 10 values of" with just the actual field title and any other raw fields with simpler names.
  2. Average Response Time should have a suffix (ms) to be more readable.

@gpop63
Copy link
Contributor

gpop63 commented Oct 23, 2025

@giorgi-imerlishvili-elastic here are some dashboard guidelines you can follow https://docs.google.com/document/d/1aTqkl0BSYPa1WeKXkKCChQaIqM0J5w4vY-8flHDUj8A/edit?tab=t.0#heading=h.qt35o6gmkwy8

Copy link

@daniela-elastic daniela-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the following first. No need for second review after you fix it so conditionally approving to save time:

  1. what does "Activity" refer to? Is that number of logs or something else? If it's number of logs can you say something like "Activity - number of logs"? what do i see if i click on the "i" icon next to "Activity"? Perhaps this could be used to provide the additional info needed
  2. X-axis name - "per 12 hours" - can you check with @ishleenk17 if this is how we want to describe the x-axis? ALso, even though you say it's per 12 hours, i can see that you're actually showing 24 hours so it's a bit confusing

@ishleenk17
Copy link
Member

Reviewing from the screenshot in the PR:

  1. The total errors is such elongated box and others are all v compact. Can we have a better alignment there.
    Something like this screenshot. 1 under the other ?
Screenshot 2025-10-29 at 8 35 29 AM
  1. Can we have the (i) icon next to log level panels ?

2. X-axis name - "per 12 hours" - can you check with @ishleenk17 if this is how we want to describe the x-axis? ALso, even though you say it's per 12 hours, i can see that you're actually showing 24 hours so it's a bit confusing

@giorgi-imerlishvili-elastic : Is your x axis the @timestamp field ? the per 12 hours, per 24 hours changes as per what time range we choose above. We usually do something like below.
Screenshot 2025-10-29 at 8 40 33 AM

@giorgi-imerlishvili-elastic
Copy link
Contributor Author

The total errors is such elongated box and others are all v compact. Can we have a better alignment there.
Something like this screenshot. 1 under the other ?

I'll try make some changes

@giorgi-imerlishvili-elastic : Is your x axis the @timestamp field ?

Yes it's @timestamp field

@muthu-mps
Copy link
Contributor

  1. I'd rename any "Top 10 values of" with just the actual field title and any other raw fields with simpler names.
  2. Average Response Time should have a suffix (ms) to be more readable.

@lucian-ioan - If this comment is addressed, Can you approve it?

Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log level panel doesn't have mention of @timestamp field like other panels/ OTherwsise looks good

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @giorgi-imerlishvili-elastic

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic merged commit 28f9488 into elastic:main Oct 30, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package azure_app_service - 0.8.0 containing this change is available at https://epr.elastic.co/package/azure_app_service/0.8.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:azure_app_service Azure App Service Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants