-
Notifications
You must be signed in to change notification settings - Fork 513
[Azure App Service] New dashboard #15487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure App Service] New dashboard #15487
Conversation
…le Logs, HTTP Logs, IPsec Audit Logs and Platform Logs.
…astic/integrations into azure_app_service
make one dashboard which contains all information
🚀 Benchmarks reportTo see the full report comment with |
| version: "0.10.0" | ||
| source: | ||
| license: "Elastic-2.0" | ||
| description: "Collect logs from Azure App Service with Elastic Agent." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add the screenshots attribute in the manifest file and include references to the dashboard image, similar to how it's done in other integrations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please make sure screenshots contain the whole dashboard, and also please add those same screenshots to the PR page (right now the screenshot in the PR description is truncated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| @@ -1,4 +1,19 @@ | |||
| # newer versions go on top | |||
| - version: "0.10.0" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having multiple changelog entries for the same PR, you can consolidate them into a single entry with a combined description.
example for reference:
| - description: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to have in one change log as well. I like combined description idea, but what about type it can only have enhancement or bugfix value as I know. This PR contains enhancement and also bugfixes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it be hard to split the changes into 2 separate PRs? or even 3 as I see 3 changelogs?
Is it OK to have several changelogs in one PR @ishleenk17 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giorgi-imerlishvili-elastic - Could we create a separate PR for the ingest pipeline changes? Since we're adding a new dashboard to the integrations, it would be better to keep these changes distinct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed bugfixes from this PR and created new one: #15591
This reverts commit 4d41407.
|
Removed log level panels from IPSecAudit and Audit logs section and updated screenshots Any ideas, what else information/panel can be added instead of those? @lucian-ioan @muthu-mps |
|
Can we update the dashboard image with real time log data. The current one shows |
I believe it's also the case for AppServiceHTTPLogs.
The goal is to try to provide value for the users. For example for the ones without Log Level:
|
Linu-Elias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please dismiss the message at the top and then capture the screenshot.
- It should be "Total Errors" instead of "Total errors" so that the titles are consistent.
- Refer to this Observability integrations dashboards best practices to see if we missed anything.
…astic/integrations into azure_app_service
|
All feedbacks were addressed please review and let me know if I missed something @lucian-ioan, @muthu-mps, @Linu-Elias |
|
@daniela-elastic - Can you take a look into the dashboard changes? |
lucian-ioan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I'd rename any "Top 10 values of" with just the actual field title and any other raw fields with simpler names.
- Average Response Time should have a suffix (ms) to be more readable.
|
@giorgi-imerlishvili-elastic here are some dashboard guidelines you can follow https://docs.google.com/document/d/1aTqkl0BSYPa1WeKXkKCChQaIqM0J5w4vY-8flHDUj8A/edit?tab=t.0#heading=h.qt35o6gmkwy8 |
daniela-elastic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the following first. No need for second review after you fix it so conditionally approving to save time:
- what does "Activity" refer to? Is that number of logs or something else? If it's number of logs can you say something like "Activity - number of logs"? what do i see if i click on the "i" icon next to "Activity"? Perhaps this could be used to provide the additional info needed
- X-axis name - "per 12 hours" - can you check with @ishleenk17 if this is how we want to describe the x-axis? ALso, even though you say it's per 12 hours, i can see that you're actually showing 24 hours so it's a bit confusing
|
Reviewing from the screenshot in the PR:
@giorgi-imerlishvili-elastic : Is your x axis the @timestamp field ? the per 12 hours, per 24 hours changes as per what time range we choose above. We usually do something like below. |
I'll try make some changes
Yes it's |
@lucian-ioan - If this comment is addressed, Can you approve it? |
ishleenk17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log level panel doesn't have mention of @timestamp field like other panels/ OTherwsise looks good
💚 Build Succeeded
History
|
|
Package azure_app_service - 0.8.0 containing this change is available at https://epr.elastic.co/package/azure_app_service/0.8.0/ |


Proposed commit message
Enhancement: Add dashboard for log categories Application Logs, Audit Logs, Console Logs, HTTP Logs, IPsec Audit Logs and Platform Logs.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots