[cisco_meraki_metrics] Fix API base URL param #15746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
History
|
ishleenk17
reviewed
Oct 24, 2025
| type: url | ||
| title: Meraki Dashboard API base URL | ||
| default: api.meraki.com | ||
| default: https://api.meraki.com |
There was a problem hiding this comment.
Why is this protocol appending required ?
There was a problem hiding this comment.
the meraki Go library fails to make requests without https://
There was a problem hiding this comment.
Curious how was it previously working ? Or was the customer adding this from their side ?
There was a problem hiding this comment.
it wasn't, in beats we used a default value if it was not set.
andrewkroh
added
Integration:cisco_meraki_metrics
ishleenk17
approved these changes
Oct 24, 2025
mykola-elastic
approved these changes
Oct 27, 2025
|
Package cisco_meraki_metrics - 0.4.2 containing this change is available at https://epr.elastic.co/package/cisco_meraki_metrics/0.4.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR fixes the api base url config param capitalization.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots