rename interface

Author: sddonne

src/platform/packages/private/kbn-esql-editor/index.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export type { DataErrorsControl, IndexEditorContext } from './src/types';
+export type { DataErrorsControl } from './src/types';
 export type { ESQLEditorProps } from './src/esql_editor';
 import { ESQLEditor } from './src/esql_editor';
 export type { ESQLEditorRestorableState } from './src/restorable_state';

src/platform/packages/private/kbn-esql-editor/src/esql_editor.tsx

@@ -130,7 +130,7 @@ const ESQLEditorInternal = function ESQLEditor({
   disableAutoFocus,
   controlsContext,
   esqlVariables,
-  indexEditorContext,
+  onOpenQueryInNewTab,
   expandToFitQueryOnMount,
   dataErrorsControl,
   formLabel,
@@ -773,7 +773,7 @@ const ESQLEditorInternal = function ESQLEditor({
     query,
     onLookupIndexCreate,
     onNewFieldsAddedToLookupIndex,
-    indexEditorContext?.onOpenIndexInDiscover
+    onOpenQueryInNewTab
   );
 
   useDebounceWithOptions(

src/platform/packages/private/kbn-esql-editor/src/types.ts

@@ -23,7 +23,6 @@ import type {
   RecommendedField,
 } from '@kbn/esql-types';
 import type { InferenceEndpointsAutocompleteResult } from '@kbn/esql-types';
-import type { EditLookupIndexContentContext } from '@kbn/index-editor';
 
 export interface ControlsContext {
   /** The editor supports the creation of controls,
@@ -36,10 +35,6 @@ export interface ControlsContext {
   onCancelControl: () => void;
 }
 
-export interface IndexEditorContext {
-  onOpenIndexInDiscover: EditLookupIndexContentContext['onOpenIndexInDiscover'];
-}
-
 export interface DataErrorsControl {
   enabled: boolean;
   onChange: (value: boolean) => void;
@@ -96,8 +91,8 @@ export interface ESQLEditorProps {
   disableAutoFocus?: boolean;
   /** Enables the creation of controls from the editor **/
   controlsContext?: ControlsContext;
-  /** Context for the lookup join index editor **/
-  indexEditorContext?: IndexEditorContext;
+  /** Opens the given query in a new Discover tab **/
+  onOpenQueryInNewTab?: (tabName: string, esqlQuery: string) => Promise<void>;
   /** The available ESQL variables from the page context this editor was opened in */
   esqlVariables?: ESQLControlVariable[];
   /** Resize the editor to fit the initially passed query on mount */

src/platform/plugins/shared/discover/public/application/main/components/top_nav/discover_topnav.tsx

@@ -99,12 +99,11 @@ export const DiscoverTopNav = ({
     onUpdateESQLQuery: stateContainer.actions.updateESQLQuery,
   });
 
-  // ES|QL lookup join index editor config
-  const openIndexInNewTab = useCallback(
-    async (indexName: string, esqlQuery: string) => {
+  const onOpenQueryInNewTab = useCallback(
+    async (tabName: string, esqlQuery: string) => {
       dispatch(
         internalStateActions.openInNewTab({
-          tabLabel: indexName,
+          tabLabel: tabName,
           appState: { query: { esql: esqlQuery } },
         })
       );
@@ -329,9 +328,7 @@ export const DiscoverTopNav = ({
               }
             : undefined
         }
-        esqlIndexEditorConfig={{
-          onOpenIndexInDiscover: openIndexInNewTab,
-        }}
+        onOpenQueryInNewTab={onOpenQueryInNewTab}
       />
       {isESQLToDataViewTransitionModalVisible && (
         <ESQLToDataViewTransitionModal onClose={onESQLToDataViewTransitionModalClose} />

src/platform/plugins/shared/unified_search/public/query_string_input/query_bar_top_row.tsx

@@ -49,7 +49,6 @@ import type { ESQLControlVariable } from '@kbn/esql-types';
 import { useKibana } from '@kbn/kibana-react-plugin/public';
 import { SplitButton } from '@kbn/split-button';
 
-import type { IndexEditorContext } from '@kbn/esql-editor';
 import { AddFilterPopover } from './add_filter_popover';
 import type { DataViewPickerProps } from '../dataview_picker';
 import { DataViewPicker } from '../dataview_picker';
@@ -234,11 +233,10 @@ export interface QueryBarTopRowProps<QT extends Query | AggregateQuery = Query>
      */
     controlsWrapper: React.ReactNode;
   };
-  /** Optional configurations for the lookup join index editor */
-  esqlIndexEditorConfig?: {
-    /** Callback function invoked to open the current index in Discover */
-    onOpenIndexInDiscover: IndexEditorContext['onOpenIndexInDiscover'];
-  };
+  /**
+   * Optional - Callback function invoked to open the current query in a new Discover tab
+   */
+  onOpenQueryInNewTab?: ESQLEditorProps['onOpenQueryInNewTab'];
   useBackgroundSearchButton?: boolean;
   showProjectPicker?: boolean;
 }
@@ -928,7 +926,7 @@ export const QueryBarTopRow = React.memo(
                 : undefined
             }
             esqlVariables={props.esqlVariablesConfig?.esqlVariables ?? []}
-            indexEditorContext={props.esqlIndexEditorConfig}
+            onOpenQueryInNewTab={props.onOpenQueryInNewTab}
           />
         )
       );

src/platform/plugins/shared/unified_search/public/search_bar/create_search_bar.tsx

@@ -279,7 +279,7 @@ export function createSearchBar({
             esqlEditorInitialState={props.esqlEditorInitialState}
             onEsqlEditorInitialStateChange={props.onEsqlEditorInitialStateChange}
             esqlVariablesConfig={props.esqlVariablesConfig}
-            esqlIndexEditorConfig={props.esqlIndexEditorConfig}
+            onOpenQueryInNewTab={props.onOpenQueryInNewTab}
             useBackgroundSearchButton={props.useBackgroundSearchButton}
           />
         </core.i18n.Context>

src/platform/plugins/shared/unified_search/public/search_bar/search_bar.tsx

@@ -163,7 +163,7 @@ export interface SearchBarOwnProps<QT extends AggregateQuery | Query = Query> {
   esqlVariablesConfig?: QueryBarTopRowProps['esqlVariablesConfig'];
 
   /** Optional configurations for the lookup join index editor */
-  esqlIndexEditorConfig?: QueryBarTopRowProps['esqlIndexEditorConfig'];
+  onOpenQueryInNewTab?: QueryBarTopRowProps['onOpenQueryInNewTab'];
 
   esqlEditorInitialState?: QueryBarTopRowProps['esqlEditorInitialState'];
   onEsqlEditorInitialStateChange?: QueryBarTopRowProps['onEsqlEditorInitialStateChange'];
@@ -785,7 +785,7 @@ export class SearchBarUI<QT extends (Query | AggregateQuery) | Query = Query> ex
           esqlEditorInitialState={this.props.esqlEditorInitialState}
           onEsqlEditorInitialStateChange={this.props.onEsqlEditorInitialStateChange}
           esqlVariablesConfig={this.props.esqlVariablesConfig}
-          esqlIndexEditorConfig={this.props.esqlIndexEditorConfig}
+          onOpenQueryInNewTab={this.props.onOpenQueryInNewTab}
           useBackgroundSearchButton={this.props.useBackgroundSearchButton}
           showProjectPicker={this.props.showProjectPicker}
         />