Skip to content

Commit c2fb827

Browse files
kibanamachinermyz
andauthored
[9.1] [ObsUX][APM][Infra] A11y fixes (#242536) (#242574)
# Backport This will backport the following commits from `main` to `9.1`: - [[ObsUX][APM][Infra] A11y fixes (#242536)](#242536) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-11T16:21:58Z","message":"[ObsUX][APM][Infra] A11y fixes (#242536)","sha":"31e185f9ebb8c24e856caa11ba8c97024f504ff4","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-infra_services","backport:version","v9.3.0","v8.19.7","v9.1.7","v9.2.1"],"title":"[ObsUX][APM][Infra] A11y fixes","number":242536,"url":"https://github.com/elastic/kibana/pull/242536","mergeCommit":{"message":"[ObsUX][APM][Infra] A11y fixes (#242536)","sha":"31e185f9ebb8c24e856caa11ba8c97024f504ff4"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1","9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242536","number":242536,"mergeCommit":{"message":"[ObsUX][APM][Infra] A11y fixes (#242536)","sha":"31e185f9ebb8c24e856caa11ba8c97024f504ff4"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <[email protected]>
1 parent 1ddf66d commit c2fb827

File tree

6 files changed

+56
-23
lines changed

6 files changed

+56
-23
lines changed

x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/e2e/service_overview/otel_edot_service_overview_and_transactions.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ describe('Service Overview', () => {
126126
cy.getByTestSubj('waterfall').should('exist');
127127
cy.getByTestSubj('accordionWaterfall').should('exist');
128128
cy.getByTestSubj('accordionWaterfall').click();
129-
cy.contains('h4', 'Transaction details');
129+
cy.contains('h2', 'Transaction details');
130130
cy.getByTestSubj('apmTransactionDetailLinkLink').should('exist');
131131
cy.getByTestSubj('apmTransactionDetailLinkLink').contains(
132132
'oteldemo.AdServiceEdotSynth/GetAds'

x-pack/solutions/observability/plugins/apm/ftr_e2e/cypress/e2e/service_overview/otel_service_overview_and_transactions.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ describe('Service Overview', () => {
142142
cy.getByTestSubj('waterfall').should('exist');
143143
cy.getByTestSubj('accordionWaterfall').should('exist');
144144
cy.getByTestSubj('accordionWaterfall').first().click();
145-
cy.contains('h4', 'Transaction details');
145+
cy.contains('h2', 'Transaction details');
146146
cy.getByTestSubj('apmTransactionDetailLinkLink').should('exist');
147147
cy.getByTestSubj('apmTransactionDetailLinkLink').contains('parent-synth');
148148
cy.getByTestSubj('apmServiceListAppLink').should('exist');

x-pack/solutions/observability/plugins/apm/public/components/app/service_map/controls.tsx

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,11 @@ export function Controls() {
185185
return (
186186
<ControlsContainer>
187187
<Panel hasShadow={true} paddingSize="none">
188-
<EuiToolTip anchorClassName="eui-displayInline" content={zoomInLabel}>
188+
<EuiToolTip
189+
anchorClassName="eui-displayInline"
190+
content={zoomInLabel}
191+
disableScreenReaderOutput
192+
>
189193
<ZoomInButton
190194
aria-label={zoomInLabel}
191195
color="text"
@@ -194,7 +198,11 @@ export function Controls() {
194198
onClick={zoomIn}
195199
/>
196200
</EuiToolTip>
197-
<EuiToolTip anchorClassName="eui-displayInline" content={zoomOutLabel}>
201+
<EuiToolTip
202+
anchorClassName="eui-displayInline"
203+
content={zoomOutLabel}
204+
disableScreenReaderOutput
205+
>
198206
<Button
199207
aria-label={zoomOutLabel}
200208
color="text"
@@ -205,7 +213,11 @@ export function Controls() {
205213
</EuiToolTip>
206214
</Panel>
207215
<Panel hasShadow={true} paddingSize="none">
208-
<EuiToolTip anchorClassName="eui-displayInline" content={centerLabel}>
216+
<EuiToolTip
217+
anchorClassName="eui-displayInline"
218+
content={centerLabel}
219+
disableScreenReaderOutput
220+
>
209221
<Button
210222
data-test-subj="centerServiceMap"
211223
aria-label={centerLabel}
@@ -217,7 +229,11 @@ export function Controls() {
217229
</Panel>
218230
{showViewFullMapButton && (
219231
<Panel hasShadow={true} paddingSize="none">
220-
<EuiToolTip anchorClassName="eui-displayInline" content={viewFullMapLabel}>
232+
<EuiToolTip
233+
anchorClassName="eui-displayInline"
234+
content={viewFullMapLabel}
235+
disableScreenReaderOutput
236+
>
221237
<Button
222238
aria-label={viewFullMapLabel}
223239
color="text"
@@ -230,7 +246,11 @@ export function Controls() {
230246
)}
231247
{downloadUrl && (
232248
<Panel hasShadow={true} paddingSize="none">
233-
<EuiToolTip anchorClassName="eui-displayInline" content={downloadLabel}>
249+
<EuiToolTip
250+
anchorClassName="eui-displayInline"
251+
content={downloadLabel}
252+
disableScreenReaderOutput
253+
>
234254
<Button
235255
aria-label={downloadLabel}
236256
color="text"

x-pack/solutions/observability/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/index.tsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -130,18 +130,21 @@ export function SpanFlyout({
130130

131131
const isLoading = isPending(status);
132132

133+
const spanDetailsTitle = i18n.translate(
134+
'xpack.apm.transactionDetails.spanFlyout.spanDetailsTitle',
135+
{
136+
defaultMessage: 'Span details',
137+
}
138+
);
139+
133140
return (
134141
<EuiPortal>
135-
<ResponsiveFlyout onClose={onClose} size="m" ownFocus={true}>
142+
<ResponsiveFlyout onClose={onClose} size="m" ownFocus={true} aria-label={spanDetailsTitle}>
136143
<EuiFlyoutHeader hasBorder>
137144
<EuiFlexGroup>
138145
<EuiFlexItem grow={false}>
139146
<EuiTitle>
140-
<h2>
141-
{i18n.translate('xpack.apm.transactionDetails.spanFlyout.spanDetailsTitle', {
142-
defaultMessage: 'Span details',
143-
})}
144-
</h2>
147+
<h2>{spanDetailsTitle}</h2>
145148
</EuiTitle>
146149
</EuiFlexItem>
147150
{span && (

x-pack/solutions/observability/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/transaction_flyout/index.tsx

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,21 +65,26 @@ export function TransactionFlyout({
6565

6666
const isLoading = isPending(status);
6767

68+
const transactionDetailsTitle = i18n.translate(
69+
'xpack.apm.transactionDetails.transFlyout.transactionDetailsTitle',
70+
{
71+
defaultMessage: 'Transaction details',
72+
}
73+
);
74+
6875
return (
6976
<EuiPortal>
70-
<ResponsiveFlyout onClose={onClose} ownFocus={true} maxWidth={false}>
77+
<ResponsiveFlyout
78+
onClose={onClose}
79+
ownFocus={true}
80+
maxWidth={false}
81+
aria-label={transactionDetailsTitle}
82+
>
7183
<EuiFlyoutHeader hasBorder>
7284
<EuiFlexGroup>
7385
<EuiFlexItem grow={false}>
7486
<EuiTitle>
75-
<h4>
76-
{i18n.translate(
77-
'xpack.apm.transactionDetails.transFlyout.transactionDetailsTitle',
78-
{
79-
defaultMessage: 'Transaction details',
80-
}
81-
)}
82-
</h4>
87+
<h2>{transactionDetailsTitle}</h2>
8388
</EuiTitle>
8489
</EuiFlexItem>
8590

x-pack/solutions/observability/plugins/apm/public/components/shared/truncate_with_tooltip/index.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,12 @@ export function TruncateWithTooltip(props: Props) {
3535

3636
return (
3737
<TooltipWrapper {...rest}>
38-
<EuiToolTip delay="long" content={text} anchorClassName={tooltipAnchorClassname}>
38+
<EuiToolTip
39+
delay="long"
40+
content={text}
41+
anchorClassName={tooltipAnchorClassname}
42+
disableScreenReaderOutput
43+
>
3944
<ContentWrapper>{content || text}</ContentWrapper>
4045
</EuiToolTip>
4146
</TooltipWrapper>

0 commit comments

Comments
 (0)