Skip to content

Commit e6ee46a

Browse files
[9.2] [SharedUX] Replace feedback snippet positive footer icon (#239741) (#239860)
# Backport This will backport the following commits from `main` to `9.2`: - [[SharedUX] Replace feedback snippet positive footer icon (#239741)](#239741) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ángeles Martínez Barrio","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-10-21T08:31:23Z","message":"[SharedUX] Replace feedback snippet positive footer icon (#239741)\n\n## Summary\n\n- Replaced `happyFace` icon with `thumbUp` one as suggested by @ek-so \n\n### Testing\n\n<img width=\"238\" height=\"125\" alt=\"Screenshot 2025-10-20 at 16 30 20\"\nsrc=\"https://github.com/user-attachments/assets/e4742e06-149a-413f-b4eb-282adea1ddbc\"\n/>","sha":"abff0ea89356982603b7586343de6ac7b5770f33","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:SharedUX","backport:version","v9.2.0","v9.3.0"],"title":"[SharedUX] Replace feedback snippet positive footer icon","number":239741,"url":"https://github.com/elastic/kibana/pull/239741","mergeCommit":{"message":"[SharedUX] Replace feedback snippet positive footer icon (#239741)\n\n## Summary\n\n- Replaced `happyFace` icon with `thumbUp` one as suggested by @ek-so \n\n### Testing\n\n<img width=\"238\" height=\"125\" alt=\"Screenshot 2025-10-20 at 16 30 20\"\nsrc=\"https://github.com/user-attachments/assets/e4742e06-149a-413f-b4eb-282adea1ddbc\"\n/>","sha":"abff0ea89356982603b7586343de6ac7b5770f33"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239741","number":239741,"mergeCommit":{"message":"[SharedUX] Replace feedback snippet positive footer icon (#239741)\n\n## Summary\n\n- Replaced `happyFace` icon with `thumbUp` one as suggested by @ek-so \n\n### Testing\n\n<img width=\"238\" height=\"125\" alt=\"Screenshot 2025-10-20 at 16 30 20\"\nsrc=\"https://github.com/user-attachments/assets/e4742e06-149a-413f-b4eb-282adea1ddbc\"\n/>","sha":"abff0ea89356982603b7586343de6ac7b5770f33"}}]}] BACKPORT--> Co-authored-by: Ángeles Martínez Barrio <[email protected]>
1 parent 0ca7758 commit e6ee46a

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

src/platform/packages/shared/shared-ux/feedback_snippet/src/__snapshots__/feedback_panel.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/platform/packages/shared/shared-ux/feedback_snippet/src/feedback_panel.tsx

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,6 @@ const thumbDownIconLabel = i18n.translate(
5050
}
5151
);
5252

53-
const faceHappyIconLabel = i18n.translate(
54-
'sharedUXPackages.feedbackSnippet.feedbackPanel.faceHappyIconLabel',
55-
{
56-
defaultMessage: 'Happy face',
57-
}
58-
);
59-
6053
/**
6154
* A panel to gather user feedback.
6255
* There are 3 available views:
@@ -139,10 +132,10 @@ export const FeedbackPanel = ({
139132
<EuiFlexItem grow={false}>
140133
<EuiIcon
141134
data-test-subj="feedbackSnippetPanelPositiveIcon"
142-
type="faceHappy"
135+
type="thumbUp"
143136
color="success"
144137
size="l"
145-
aria-label={faceHappyIconLabel}
138+
aria-label={thumbUpIconLabel}
146139
/>
147140
</EuiFlexItem>
148141
);

0 commit comments

Comments
 (0)