[Defend Workflows][Osquery] Multiple fixes for pack management #241655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szwarckonrad
added
release_note:skip
This was referenced Nov 3, 2025
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
tomsonpl
approved these changes
Nov 3, 2025
szwarckonrad
force-pushed
the
osquery-small-fixes
branch
from
c5a5786 to
228611f
Compare
botelastic
bot
added
the
Team:obs-ux-management
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
szwarckonrad
force-pushed
the
osquery-small-fixes
branch
from
228611f to
c5a5786
Compare
- Fix global packs not preserving policy references when creating new integrations or deleting policies - Fix pack edit cancel button redirecting to undefined page - Update pack confirmation modal to display both policy and agent counts - Update live query route privileges to use readLiveQueries Closes elastic/security-team#14422 Closes elastic/security-team#14423 Closes elastic/security-team#14424
szwarckonrad
force-pushed
the
osquery-small-fixes
branch
from
c5a5786 to
ac85b24
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2025
…ic#241655) This PR combines three separate osquery pack management fixes: 1. **Fix global packs not preserving policy references**: Resolves issues where global packs would lose references to existing policies when creating new osquery integrations or deleting policies. Fixed by including `pack.references` in SavedObject mapping and correcting the filter logic in the delete callback. https://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930 2. **Fix pack edit cancel button**: Fixes the cancel button on the pack edit page that was redirecting to `/packs/undefined` instead of the correct pack details page. 3. **Update pack confirmation modal**: Improves the confirmation modal to clearly display both the number of agent policies and the number of agents that will be affected by pack updates. <img width="581" height="300" alt="Screenshot 2025-10-31 at 16 47 11" src="https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91" /> Closes elastic/security-team#14422 Closes elastic/security-team#14423 Closes elastic/security-team#14424 (cherry picked from commit eebbf7b)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
szwarckonrad
added a commit
that referenced
this pull request
Nov 5, 2025
…241655) (#241964) # Backport This will backport the following commits from `main` to `9.1`: - [[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)](#241655) <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-05T11:44:31Z","message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.3.0"],"title":"[Defend Workflows][Osquery] Multiple fixes for pack management","number":241655,"url":"https://github.com/elastic/kibana/pull/241655","mergeCommit":{"message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/241962","number":241962,"state":"OPEN"},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/241959","number":241959,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/241655","number":241655,"mergeCommit":{"message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be"}}]}] BACKPORT-->
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2025
…241655) (#241959) # Backport This will backport the following commits from `main` to `9.2`: - [[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)](#241655) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-05T11:44:31Z","message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.3.0"],"title":"[Defend Workflows][Osquery] Multiple fixes for pack management","number":241655,"url":"https://github.com/elastic/kibana/pull/241655","mergeCommit":{"message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.2"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/241655","number":241655,"mergeCommit":{"message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be"}}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <[email protected]>
szwarckonrad
added a commit
that referenced
this pull request
Nov 5, 2025
…#241655) (#241962) # Backport This will backport the following commits from `main` to `8.19`: - [[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)](#241655) <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-05T11:44:31Z","message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.3.0"],"title":"[Defend Workflows][Osquery] Multiple fixes for pack management","number":241655,"url":"https://github.com/elastic/kibana/pull/241655","mergeCommit":{"message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/241959","number":241959,"state":"OPEN"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/241655","number":241655,"mergeCommit":{"message":"[Defend Workflows][Osquery] Multiple fixes for pack management (#241655)\n\nThis PR combines three separate osquery pack management fixes:\n\n1. **Fix global packs not preserving policy references**: Resolves\nissues where global packs would lose references to existing policies\nwhen creating new osquery integrations or deleting policies. Fixed by\nincluding `pack.references` in SavedObject mapping and correcting the\nfilter logic in the delete callback.\n\n\n\nhttps://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930\n\n2. **Fix pack edit cancel button**: Fixes the cancel button on the pack\nedit page that was redirecting to `/packs/undefined` instead of the\ncorrect pack details page.\n\n3. **Update pack confirmation modal**: Improves the confirmation modal\nto clearly display both the number of agent policies and the number of\nagents that will be affected by pack updates.\n\n<img width=\"581\" height=\"300\" alt=\"Screenshot 2025-10-31 at 16 47 11\"\nsrc=\"https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91\"\n/>\n\nCloses https://github.com/elastic/security-team/issues/14422\nCloses https://github.com/elastic/security-team/issues/14423\nCloses https://github.com/elastic/security-team/issues/14424","sha":"eebbf7be68df5cfe998767f6727d1afb3f14f9be"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
wildemat
pushed a commit
to wildemat/kibana
that referenced
this pull request
Nov 5, 2025
…ic#241655) This PR combines three separate osquery pack management fixes: 1. **Fix global packs not preserving policy references**: Resolves issues where global packs would lose references to existing policies when creating new osquery integrations or deleting policies. Fixed by including `pack.references` in SavedObject mapping and correcting the filter logic in the delete callback. https://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930 2. **Fix pack edit cancel button**: Fixes the cancel button on the pack edit page that was redirecting to `/packs/undefined` instead of the correct pack details page. 3. **Update pack confirmation modal**: Improves the confirmation modal to clearly display both the number of agent policies and the number of agents that will be affected by pack updates. <img width="581" height="300" alt="Screenshot 2025-10-31 at 16 47 11" src="https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91" /> Closes elastic/security-team#14422 Closes elastic/security-team#14423 Closes elastic/security-team#14424
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Nov 5, 2025
…ic#241655) This PR combines three separate osquery pack management fixes: 1. **Fix global packs not preserving policy references**: Resolves issues where global packs would lose references to existing policies when creating new osquery integrations or deleting policies. Fixed by including `pack.references` in SavedObject mapping and correcting the filter logic in the delete callback. https://github.com/user-attachments/assets/452b52b3-198a-428f-a63e-e33857bfa930 2. **Fix pack edit cancel button**: Fixes the cancel button on the pack edit page that was redirecting to `/packs/undefined` instead of the correct pack details page. 3. **Update pack confirmation modal**: Improves the confirmation modal to clearly display both the number of agent policies and the number of agents that will be affected by pack updates. <img width="581" height="300" alt="Screenshot 2025-10-31 at 16 47 11" src="https://github.com/user-attachments/assets/fa14067f-de8f-4377-8898-411a0454fe91" /> Closes elastic/security-team#14422 Closes elastic/security-team#14423 Closes elastic/security-team#14424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines three separate osquery pack management fixes:
pack.referencesin SavedObject mapping and correcting the filter logic in the delete callback.Screen.Recording.2025-11-03.at.12.08.25.mov
Fix pack edit cancel button: Fixes the cancel button on the pack edit page that was redirecting to
/packs/undefinedinstead of the correct pack details page.Update pack confirmation modal: Improves the confirmation modal to clearly display both the number of agent policies and the number of agents that will be affected by pack updates.
Closes https://github.com/elastic/security-team/issues/14422
Closes https://github.com/elastic/security-team/issues/14423
Closes https://github.com/elastic/security-team/issues/14424