Skip to content

[ES|QL] Editor commands using stale dependencies #245455

@davismcphee

Description

@davismcphee

In #244453 a fix was added to the ES|QL editor to prevent re-registering Monaco commands on every React render. However, now those command callbacks are using stale dependencies (whichever ones exist when editorDidMount is called).

This causes issues in Discover such as ES|QL controls not being created as expected, and command + return not triggering searches. It likely also affects other places where the editor is used.

This video demonstrates the controls and search issues along with the console errors logged:

stale_deps.mp4

This PoC fixes the controls problem to demonstrate the issue, but the real fix for all stale dependencies would be more involved: #245454.

Metadata

Metadata

Assignees

Labels

Feature:ES|QLES|QL related features in KibanaTeam:ESQLES|QL related features in Kibana t//bugFixes for quality problems that affect the customer experienceimpact:highAddressing this issue will have a high level of impact on the quality/strength of our product.

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions