[ES|QL] Simplified search visor #242123
Merged
[ES|QL] Simplified search visor #242123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
force-pushed
the
simplified-search-esql
branch
from
5695fec to
ca86f3f
Compare
stratoula
added
Feature:ES|QL
stratoula
commented
Nov 14, 2025
| ] | ||
| ); | ||
|
|
||
| const onUpdateAndSubmitQuery = useCallback( |
Contributor
Author
There was a problem hiding this comment.
One callback to share for both the starred queries and the visor
stratoula
added
backport:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
sddonne
reviewed
Nov 20, 2025
Contributor
sddonne
left a comment
sddonne
left a comment
There was a problem hiding this comment.
Looks really beautiful!!
Found what I think it's a little bug when used within Controls flyout
src/platform/packages/private/kbn-esql-editor/src/editor_visor/index.tsx
Show resolved
Hide resolved
sddonne
approved these changes
Nov 21, 2025
Contributor
sddonne
left a comment
sddonne
left a comment
There was a problem hiding this comment.
lgtm! haven't test it again
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
## Summary Closes elastic#220050 <img width="1509" height="224" alt="image" src="https://github.com/user-attachments/assets/3634ceb8-c335-4be6-a8fc-5c480995229b" /> Adds a quick search functionality in the editor. The visor: - doesn't have a double biding functionality. It is an one off feature. You use it to update your query but it is not updated if the query changes. Only the indices - It closes if the user starts typing in the editor - It updates the query with the KQL function, it doesnt continue the current query, it overwrites it ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #220050
Adds a quick search functionality in the editor. The visor:
Checklist