-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add TopNavMenuBeta to navigation plugin #243578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TopNavMenuBeta to navigation plugin #243578
Conversation
1fbf98a to
a201a2a
Compare
a201a2a to
f72ea1c
Compare
Dosant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no actions items for now, just some thoughts for later:
src/platform/plugins/shared/navigation/public/top_nav_menu_beta/top_nav_menu_beta.tsx
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/navigation/public/top_nav_menu_beta/top_nav_menu_beta.stories.tsx
Outdated
Show resolved
Hide resolved
54d6af9 to
2b944fd
Compare
73e9d7a to
d7afe89
Compare
fb0d5b1 to
5036ced
Compare
f5fe1e9 to
43bd721
Compare
43bd721 to
120d724
Compare
259c31d to
69a5538
Compare
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsasync chunk count
References to deprecated APIs
Unreferenced deprecated APIs
History
|
Dosant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good, but I haven't tested the actual UI.
Approving to unblock the general direction because I'll be out for the rest of the week
* commit '6647f813c9fa03ac0378e3d4756246e8dc4b4c76': (33 commits) [Detection Engine] Extracts Rules/Alerts/Exceptions permission to new Rules feature privileges (elastic#239634) [Agent Builder] Add Intro Tour (elastic#245551) Add datastream lifecycle support to indices metadata (elastic#245548) [Serverless] Update preconfigured connectors (elastic#245445) [Metrics][Discover] Discover to prefer line chars for time series data (elastic#244595) Update dependency @elastic/ebt to ^1.4.1 (main) (elastic#241629) [One Workflow] fix: request bodies with oneof schemas (`kibana.SetAlertsStatus`, etc) (elastic#245344) Update dependency ai to v5 (elastic#244675) Fix Discover trace waterfall behavior with duplicate spans (elastic#244984) [FSH] Migrated fs usage to kbn/fs for sample ingest (elastic#244163) Streamlang: Unskip type coercion test (elastic#245519) [Response Ops][Reporting] Fixing error in calculating delay value between retries (elastic#245431) Add TopNavMenuBeta to navigation plugin (elastic#243578) [scout] support custom servers configuration (elastic#244306) [Fleet] Run agentless background sync without dry run (elastic#245286) Fix Change Password Flaky Test (elastic#245443) Add new gap fill status for rules (elastic#242595) [Kibana Search] Move SLOs higher up in search results (elastic#245518) feat(slo): introduce find SLO instances internal route (elastic#245333) [FSH] Dropped unnecessary `fs` persistence for synthetics project code (elastic#244338) ...
Summary
This PR adds
TopNavMenuBetacomponent to navigation plugin, which provides new design of app menu.Preview screenshot from Storybook of how it would look in dashboard application (edit mode):
Preview screenshot from Storybook of how it would look in discover application:
TopNavMenuBetaoffers a more restricted API thanTopNavMenuDecoupling from
UnifiedSearch- top nav menu will no longer be bundled with unified search. You will need to directly import unified search and render it.Removal of badges - badges will no longer be available in top nav menu. According to UX guidelines, current badges should be moved to use breadcrumbs extension API.
itemscan only beEuiHeaderLink(a button with typetext). For more advanced use cases, use action buttons.Action buttons -
TopNavMenuBetaintroduces action buttons:primaryActionButton- this is meant to be used for primary actions (e.g saving), can be either anEuiButtonor a split button, always placed as the rightmost itemsecondaryActionButton- this is meant for secondary actions (e.g adding a new panel), can only be anEuiButton, placed to the left fromprimaryActionButtonRemoval of
TopNavMenuExtensionsRegistry- registering global items is no longer possible, add items locally to your application.Closes: https://github.com/elastic/kibana-team/issues/2270
Closes: https://github.com/elastic/kibana-team/issues/2273
Closes: https://github.com/elastic/kibana-team/issues/2272
Closes: https://github.com/elastic/kibana-team/issues/2352