-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Agent Builder] add conditional availability for built-in agents #245497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pgayvallet
wants to merge
2
commits into
elastic:main
Choose a base branch
from
pgayvallet:ab-xxx-agent-availability-handler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Agent Builder] add conditional availability for built-in agents #245497
pgayvallet
wants to merge
2
commits into
elastic:main
from
pgayvallet:ab-xxx-agent-availability-handler
+623
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI Steps |
Contributor
Author
|
/ci |
joemcelroy
reviewed
Dec 8, 2025
| */ | ||
| export interface AgentAvailabilityResult { | ||
| /** | ||
| * Whether the tool is available or not. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, same with below
Suggested change
| * Whether the tool is available or not. | |
| * Whether the agent is available or not. |
joemcelroy
reviewed
Dec 8, 2025
| const result: ToolAvailabilityResult = { status: 'available' }; | ||
| mockHandler.mockResolvedValue(result); | ||
|
|
||
| const config: ToolAvailabilityConfig = { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong type
joemcelroy
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This PR does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
v9.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Equivalent of #238274 for built-in agents