-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[streams][significant events] Add evidence to generated query #245546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/actionable-obs-team (Team:actionable-obs) |
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
miltonhultgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally ✅
x-pack/platform/plugins/shared/streams/server/lib/streams/assets/asset_client.ts
Show resolved
Hide resolved
x-pack/platform/plugins/shared/streams/server/lib/streams/assets/storage_settings.ts
Outdated
Show resolved
Hide resolved
flash1293
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review only, just changes significant events stuff
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
cc @klacabane |
Summary
Add
query.evidencefield that stores the reason a query was generated. No UI implemented in this changeExamples