Skip to content

Commit 2daa98c

Browse files
committed
only remove gemspecs for duplicated stdlib gems
1 parent f474d49 commit 2daa98c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

rakelib/artifacts.rake

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,12 @@ namespace "artifact" do
123123

124124
# Exclude default gems duplicates
125125
default_duplicates.each do |gem_name|
126+
# CODEREVIEW: removing the code itself causes issues with gem loading. Remove only the gemspecs
127+
# for duplicated gems. This should help the code scanning case.
126128
exclusions << "vendor/jruby/lib/ruby/gems/shared/specifications/default/#{gem_name}-*.gemspec"
127-
exclusions << "vendor/jruby/lib/ruby/stdlib/#{gem_name}.rb"
128-
exclusions << "vendor/jruby/lib/ruby/stdlib/#{gem_name}/**/*"
129-
exclusions << "vendor/jruby/lib/ruby/stdlib/#{gem_name}"
129+
# exclusions << "vendor/jruby/lib/ruby/stdlib/#{gem_name}.rb"
130+
# exclusions << "vendor/jruby/lib/ruby/stdlib/#{gem_name}/**/*"
131+
# exclusions << "vendor/jruby/lib/ruby/stdlib/#{gem_name}"
130132
end
131133

132134
exclusions

0 commit comments

Comments
 (0)