Skip to content

Commit add3a2a

Browse files
committed
ci: run tests on Ubuntu and Windows
1 parent 63bdf7d commit add3a2a

File tree

1 file changed

+16
-3
lines changed

1 file changed

+16
-3
lines changed

.github/workflows/test.yml

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,24 @@ jobs:
2222
- '22.12.x'
2323
os:
2424
- macos-latest
25-
# TODO(dsanders11: Enable these once we fix tests on those platforms in CI
26-
# - ubuntu-latest
27-
# - windows-latest
25+
- ubuntu-latest
26+
- windows-latest
2827
runs-on: "${{ matrix.os }}"
2928
steps:
29+
- name: Configure ubuntu
30+
if: contains(matrix.os, 'ubuntu')
31+
shell: bash
32+
run: |-
33+
# Setup a virtual display for Electron tests
34+
sudo apt install -y xvfb
35+
sudo Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
36+
echo "DISPLAY=:99" >> $GITHUB_ENV
37+
38+
# Workaround for Electron AppImage apps failing to initialize on Ubuntu due to AppArmor restrictions
39+
# Disables unprivileged user namespaces restriction to allow Electron apps to run
40+
# Reference: https://github.com/electron/electron/issues/42510
41+
: https://github.com/electron-userland/electron-builder/issues/8440
42+
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
3043
- name: Checkout
3144
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3245
- name: Setup Node.js

0 commit comments

Comments
 (0)