feat: update breakpad (#32)

Author: nornagon

.gitmodules

@@ -1,3 +1,3 @@
 [submodule "deps/breakpad"]
 	path = deps/breakpad
-	url = https://github.com/electron/chromium-breakpad.git
+	url = https://chromium.googlesource.com/breakpad/breakpad

.npmignore

@@ -0,0 +1,23 @@
+const fs = require('fs')
+const path = require('path')
+const {spawnSync} = require('child_process')
+
+const buildDir = path.join(__dirname, 'build')
+if (!fs.existsSync(buildDir)) {
+  fs.mkdirSync(buildDir, {recursive: true})
+}
+spawnSync(path.join(__dirname, 'deps', 'breakpad', 'configure'), [], {
+  cwd: buildDir,
+  env: {
+    ...process.env,
+    CPPFLAGS: `-I${path.relative(buildDir, path.join(__dirname, 'deps'))}`
+  },
+  stdio: 'inherit'
+})
+const targets = ['src/processor/minidump_stackwalk']
+if (process.platform === 'linux') {
+  targets.push('src/tools/linux/dump_syms/dump_syms')
+}
+spawnSync('make', ['-C', buildDir, '-j', require('os').cpus().length, ...targets], {
+  stdio: 'inherit'
+})

bin/minidump_stackwalk

@@ -2,33 +2,21 @@ var fs = require('fs')
 var path = require('path')
 var spawn = require('child_process').spawn
 
-var searchPaths = [
-  path.resolve(__dirname, '..', 'build', 'Release'),
-  path.resolve(__dirname, '..', 'build', 'Debug'),
-  path.resolve(__dirname, '..', 'bin')
-]
-
-function searchCommand (command) {
-  var binaryPath = null
-  if (process.platform === 'win32') {
-    command += '.exe'
-    binaryPath = path.join(__dirname, '..', 'deps', 'breakpad', command)
-    if (fs.existsSync(binaryPath)) {
-      return binaryPath
-    }
-  } else {
-    for (var i in searchPaths) {
-      binaryPath = path.join(searchPaths[i], command)
-      if (fs.existsSync(binaryPath)) {
-        return binaryPath
-      }
+const exe = process.platform === 'win32' ? '.exe' : ''
+const commands = {
+  minidump_stackwalk: path.resolve(__dirname, '..', 'build', 'src', 'processor', 'minidump_stackwalk') + exe,
+  dump_syms: (() => {
+    if (process.platform === 'darwin') {
+      return path.resolve(__dirname, '..', 'build', 'src', 'tools', 'mac', 'dump_syms', 'dump_syms_mac')
+    } else if (process.platform === 'linux') {
+      return path.resolve(__dirname, '..', 'build', 'src', 'tools', 'linux', 'dump_syms', 'dump_syms')
     }
-  }
+  })()
 }
 
 function execute (command, args, callback) {
-  var stdout = new Buffer(0)
-  var stderr = new Buffer(0)
+  var stdout = Buffer.alloc(0)
+  var stderr = Buffer.alloc(0)
   var child = spawn(command, args)
   child.stdout.on('data', function (chunk) {
     stdout = Buffer.concat([stdout, chunk])
@@ -54,7 +42,7 @@ module.exports.walkStack = function (minidump, symbolPaths, callback, commandArg
     symbolPaths = []
   }
 
-  var stackwalk = searchCommand('minidump_stackwalk')
+  var stackwalk = commands.minidump_stackwalk
   if (!stackwalk) {
     callback(new Error('Unable to find "minidump_stackwalk"'))
     return
@@ -66,7 +54,7 @@ module.exports.walkStack = function (minidump, symbolPaths, callback, commandArg
 }
 
 module.exports.dumpSymbol = function (binary, callback) {
-  var dumpsyms = searchCommand('dump_syms')
+  var dumpsyms = commands.dump_syms
   if (!dumpsyms) {
     callback(new Error('Unable to find "dump_syms"'))
     return

binding.gyp

@@ -15,13 +15,20 @@
     "url": "https://github.com/electron/node-minidump/issues"
   },
   "scripts": {
-    "test": "mocha test && standard"
+    "test": "mocha test && standard",
+    "install": "node build.js"
   },
   "devDependencies": {
     "electron-download": "^3.0.1",
     "extract-zip": "^1.5.0",
     "mocha": "^3.1.2",
     "standard": "^8.4.0",
     "temp": "^0.8.3"
-  }
+  },
+  "files": [
+    "LICENSE.md",
+    "README.md",
+    "/bin",
+    "/lib"
+  ]
 }

build.js

@@ -74,7 +74,7 @@ describe('minidump', function () {
 
   describe('dumpSymbol()', function () {
     it('calls back with a minidump', function (done) {
-      if (process.platform === 'win32') return this.skip()
+      if (process.platform !== 'linux') return this.skip()
 
       downloadElectron(function (error, binaryPath) {
         if (error) return done(error)