Merge pull request #20 from electron/upgrade-breakpad

Upgrade breakpad

Author: kevinsawicki

.gitignore

@@ -1,3 +1,4 @@
 /node_modules
 /build
 *.swp
+npm-debug.log

.npmignore

@@ -1,4 +1,5 @@
 .gitmodules
 .npmignore
 .travis.yml
+npm-debug.log
 test

.travis.yml

@@ -5,6 +5,7 @@ node_js:
 
 os:
 - osx
+- linux
 
 notifications:
   email:

binding.gyp

@@ -8,7 +8,7 @@
         }, {
           'dependencies': [
             'deps/breakpad/breakpad.gyp:minidump_stackwalk',
-            'deps/breakpad/breakpad.gyp:dump_syms',
+            'deps/breakpad/breakpad.gyp:dump_syms#host',
           ],
         }],
       ],

common.gypi

@@ -2,6 +2,7 @@
   'variables': {
     'chromeos%': 0,
     'os_bsd%': 0,
+    'mac_deployment_target%': '10.9',
   },
   'target_defaults': {
     'conditions': [
@@ -11,6 +12,8 @@
       ['OS=="mac"', {
         'xcode_settings': {
           'OTHER_CFLAGS': ['-w'],
+          'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
+          'CLANG_CXX_LIBRARY': 'libc++',
         }
       }]
     ]

deps/breakpad

@@ -7,7 +7,7 @@ var extractZip = require('extract-zip')
 var temp = require('temp').track()
 
 describe('minidump', function () {
-  this.timeout(60000)
+  this.timeout(3 * 60 * 1000)
 
   describe('walkStack()', function () {
     describe('macOS dump', function () {
@@ -49,11 +49,29 @@ describe('minidump', function () {
         })
       })
     })
+
+    describe('Linux dump', function () {
+      it('calls back with a report', function (done) {
+        downloadElectronSymbols('linux', function (error, symbolsPath) {
+          if (error) return done(error)
+
+          var dumpPath = path.join(__dirname, 'fixtures', 'linux.dmp')
+          minidump.walkStack(dumpPath, symbolsPath, function (error, report) {
+            if (error) return done(error)
+
+            report = report.toString()
+            assert.notEqual(report.length, 0)
+            assert.notEqual(report.indexOf('electron!Crash [atom_bindings.cc : 27 + 0x0]'), -1)
+            done()
+          })
+        })
+      })
+    })
   })
 
   describe('dumpSymbol()', function () {
     it('calls back with a minidump', function (done) {
-      if (process.platform !== 'darwin') return this.skip()
+      if (process.platform === 'win32') return this.skip()
 
       downloadElectron(function (error, binaryPath) {
         if (error) return done(error)
@@ -73,15 +91,20 @@ var downloadElectron = function (callback) {
   electronDownload({
     version: '1.4.3',
     arch: 'x64',
-    platform: 'darwin',
+    platform: process.platform,
     quiet: true
   }, function (error, zipPath) {
     if (error) return callback(error)
 
     var electronPath = temp.mkdirSync('node-minidump-')
     extractZip(zipPath, {dir: electronPath}, function (error) {
       if (error) return callback(error)
-      callback(null, path.join(electronPath, 'Electron.app', 'Contents', 'MacOS', 'Electron'))
+
+      if (process.platform === 'darwin') {
+        callback(null, path.join(electronPath, 'Electron.app', 'Contents', 'MacOS', 'Electron'))
+      } else {
+        callback(null, path.join(electronPath, 'electron'))
+      }
    })
   })
 }