Update gateway resolver tests to return default gateway on error

p1gp1g · p1gp1g · commit 65b0eed40222 · 2025-11-17T11:37:15.000+01:00
diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushGatewayUrlResolverTest.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushGatewayUrlResolverTest.kt
@@ -59,7 +59,7 @@ class DefaultUnifiedPushGatewayUrlResolverTest {
     }
 
     @Test
-    fun `resolve Error returns the url if no current url is available`() {
+    fun `resolve Error returns the default gateway url if no current url is available`() {
         val sut = createDefaultUnifiedPushGatewayUrlResolver(
             unifiedPushStore = FakeUnifiedPushStore(
                 getPushGatewayResult = { instance ->
@@ -69,7 +69,7 @@ class DefaultUnifiedPushGatewayUrlResolverTest {
             )
         )
         val result = sut.resolve(
-            gatewayResult = UnifiedPushGatewayResolverResult.Error("aUrl"),
+            gatewayResult = UnifiedPushGatewayResolverResult.Error(FakeDefaultPushGatewayHttpUrlProvider().provide()),
             instance = "instance",
         )
         assertThat(result).isEqualTo("aUrl")

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ class DefaultUnifiedPushGatewayUrlResolverTest {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`@Test`
`62`		- fun `resolve Error returns the url if no current url is available`() {
	`62`	+ fun `resolve Error returns the default gateway url if no current url is available`() {
`63`	`63`	`val sut = createDefaultUnifiedPushGatewayUrlResolver(`
`64`	`64`	`unifiedPushStore = FakeUnifiedPushStore(`
`65`	`65`	`getPushGatewayResult = { instance ->`
`@@ -69,7 +69,7 @@ class DefaultUnifiedPushGatewayUrlResolverTest {`
`69`	`69`	`)`
`70`	`70`	`)`
`71`	`71`	`val result = sut.resolve(`
`72`		`- gatewayResult = UnifiedPushGatewayResolverResult.Error("aUrl"),`
	`72`	`+ gatewayResult = UnifiedPushGatewayResolverResult.Error(FakeDefaultPushGatewayHttpUrlProvider().provide()),`
`73`	`73`	`instance = "instance",`
`74`	`74`	`)`
`75`	`75`	`assertThat(result).isEqualTo("aUrl")`