-moving openSystemOverlaySettings to system

- moving the dpToPx function to the ScreenSizeHelpers.kt

Author: jesus

libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/system/SystemUtils.kt

@@ -196,6 +196,24 @@ fun Context.openGooglePlay(
     }
 }
 
+/**
+ * Opens the system settings for the current app to allow drawing over other apps.
+ */
+fun Context.openSystemOverlaySettings() {
+    val intent = Intent(
+        Settings.ACTION_MANAGE_OVERLAY_PERMISSION,
+        "package:$packageName".toUri()
+    ).apply {
+        addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
+    }
+    try {
+        startActivity(intent)
+    } catch (e: ActivityNotFoundException) {
+        toast(getString(R.string.error_no_compatible_app_found))
+    }
+}
+
+
 // Not in KTX anymore
 fun Context.toast(resId: Int) {
     Toast.makeText(this, resId, Toast.LENGTH_SHORT).show()

libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/floatingvideo/FloatingVideoService.kt

@@ -31,11 +31,12 @@ import androidx.savedstate.SavedStateRegistry
 import androidx.savedstate.SavedStateRegistryController
 import androidx.savedstate.SavedStateRegistryOwner
 import androidx.savedstate.setViewTreeSavedStateRegistryOwner
-import androidx.core.net.toUri
+import io.element.android.libraries.androidutils.system.openSystemOverlaySettings
 import io.element.android.libraries.mediaviewer.impl.floatingvideo.ui.FloatingVideoOverlay
 import io.element.android.libraries.mediaviewer.impl.floatingvideo.util.getScreenHeight
 import dev.zacsweers.metro.Inject
 import io.element.android.libraries.architecture.bindings
+import io.element.android.libraries.mediaviewer.impl.floatingvideo.util.dpToPx
 import io.element.android.libraries.mediaviewer.impl.floatingvideo.util.getUri
 import io.element.android.libraries.mediaviewer.impl.floatingvideo.util.maximizeWindowHelper
 import io.element.android.libraries.mediaviewer.impl.floatingvideo.util.minimizeWindowHelper
@@ -59,6 +60,8 @@ class FloatingVideoService : Service(), LifecycleOwner, SavedStateRegistryOwner
         const val EXTRA_VIDEO_ID = "video_id"
         const val EXTRA_POSITION = "position"
 
+        private const val INITIAL_FLOATING_WINDOW_OFFSET_Y = 300
+
         @SuppressLint("ObsoleteSdkInt")
         fun startFloating(
             context: Context, videoData: MediaViewerPageData.MediaViewerData, position: Long = 0L
@@ -69,13 +72,7 @@ class FloatingVideoService : Service(), LifecycleOwner, SavedStateRegistryOwner
                 Toast.makeText(context, "To show the floating video, please allow 'Display over other apps' permission.", Toast.LENGTH_LONG).show()
 
                 // Request overlay permission
-                val intent = Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION).apply {
-                    data = "package:${context.packageName}".toUri()
-                    addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
-                }
-
-
-                context.startActivity(intent)
+                context.openSystemOverlaySettings()
                 return
             }
 
@@ -160,7 +157,6 @@ class FloatingVideoService : Service(), LifecycleOwner, SavedStateRegistryOwner
 
     private fun createFloatingView() {
         removeFloatingView()
-        windowManager = getSystemService(WINDOW_SERVICE) as WindowManager
 
         windowLayoutParams = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
             WindowManager.LayoutParams(
@@ -183,7 +179,7 @@ class FloatingVideoService : Service(), LifecycleOwner, SavedStateRegistryOwner
 
         windowLayoutParams.gravity = Gravity.TOP or Gravity.START
         windowLayoutParams.x = 0
-        windowLayoutParams.y = windowManager.getScreenHeight() - dpToPx(300)
+        windowLayoutParams.y = windowManager.getScreenHeight() - dpToPx(INITIAL_FLOATING_WINDOW_OFFSET_Y)
 
         val composeView = ComposeView(this).apply {
             setViewTreeLifecycleOwner(this@FloatingVideoService)
@@ -250,10 +246,6 @@ class FloatingVideoService : Service(), LifecycleOwner, SavedStateRegistryOwner
         onVideoComplete()
     }
 
-    private  fun dpToPx(dp: Int): Int {
-        return (dp * resources.displayMetrics.density).toInt()
-    }
-
     private fun onVideoComplete() {
         removeFloatingView()
         lifecycleRegistry.handleLifecycleEvent(Lifecycle.Event.ON_DESTROY)

libraries/mediaviewer/impl/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/floatingvideo/util/ScreenSizeHelpers.kt

@@ -7,6 +7,7 @@
 
 package io.element.android.libraries.mediaviewer.impl.floatingvideo.util
 
+import android.content.Context
 import android.graphics.Point
 import android.os.Build
 import android.util.DisplayMetrics
@@ -144,3 +145,7 @@ private fun calculateDimensions(
     val height = (width / aspectRatio).toInt()
     return Point(width, height)
 }
+
+fun Context.dpToPx(dp: Int): Int {
+    return (dp * resources.displayMetrics.density).toInt()
+}