Update gateway resolver tests to return default gateway on error

p1gp1g · p1gp1g · commit dfc8b70e54d1 · 2025-11-17T12:26:37.000+01:00
diff --git a/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushGatewayUrlResolverTest.kt b/libraries/pushproviders/unifiedpush/src/test/kotlin/io/element/android/libraries/pushproviders/unifiedpush/DefaultUnifiedPushGatewayUrlResolverTest.kt
@@ -59,7 +59,7 @@ class DefaultUnifiedPushGatewayUrlResolverTest {
     }
 
     @Test
-    fun `resolve Error returns the url if no current url is available`() {
+    fun `resolve Error returns the default gateway url if no current url is available`() {
         val sut = createDefaultUnifiedPushGatewayUrlResolver(
             unifiedPushStore = FakeUnifiedPushStore(
                 getPushGatewayResult = { instance ->
@@ -72,7 +72,7 @@ class DefaultUnifiedPushGatewayUrlResolverTest {
             gatewayResult = UnifiedPushGatewayResolverResult.Error("aUrl"),
             instance = "instance",
         )
-        assertThat(result).isEqualTo("aUrl")
+        assertThat(result).isEqualTo(FakeDefaultPushGatewayHttpUrlProvider().provide())
     }
 
     private fun createDefaultUnifiedPushGatewayUrlResolver(

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ class DefaultUnifiedPushGatewayUrlResolverTest {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`@Test`
`62`		- fun `resolve Error returns the url if no current url is available`() {
	`62`	+ fun `resolve Error returns the default gateway url if no current url is available`() {
`63`	`63`	`val sut = createDefaultUnifiedPushGatewayUrlResolver(`
`64`	`64`	`unifiedPushStore = FakeUnifiedPushStore(`
`65`	`65`	`getPushGatewayResult = { instance ->`
`@@ -72,7 +72,7 @@ class DefaultUnifiedPushGatewayUrlResolverTest {`
`72`	`72`	`gatewayResult = UnifiedPushGatewayResolverResult.Error("aUrl"),`
`73`	`73`	`instance = "instance",`
`74`	`74`	`)`
`75`		`- assertThat(result).isEqualTo("aUrl")`
	`75`	`+ assertThat(result).isEqualTo(FakeDefaultPushGatewayHttpUrlProvider().provide())`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`private fun createDefaultUnifiedPushGatewayUrlResolver(`