Skip to content

Add a shortcut return when there are no events to purge. #19093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2025
Merged

Add a shortcut return when there are no events to purge. #19093

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0347508
Add a shortcut exit when no events to purge
reivilibre Oct 23, 2025
bdab99f
Newsfile
reivilibre Oct 23, 2025
d2b407a
Shortcut when no events are to be deleted
reivilibre Oct 28, 2025
83952a7
Revert "Shortcut when no events are to be deleted"
reivilibre Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/19093.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a shortcut return when there are no events to purge.
10 changes: 10 additions & 0 deletions synapse/storage/databases/main/purge_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,16 @@ def _purge_history_txn(

txn.execute("SELECT event_id, should_delete FROM events_to_purge")
event_rows = txn.fetchall()

if len(event_rows) == 0:
logger.info("[purge] no events found to purge")

# For the sake of cleanliness: drop the temp table.
# This will commit the txn in sqlite, so make sure to keep this actually last.
txn.execute("DROP TABLE events_to_purge")
# no referenced state groups
return set()

logger.info(
"[purge] found %i events before cutoff, of which %i can be deleted",
len(event_rows),
Expand Down
Loading