refactor(randomInt): remove unnecessary overload, clean up comments and test.

Author: ElijahKotyluk

packages/graalvm/src/main/kotlin/elide/runtime/intrinsics/js/node/CryptoAPI.kt

@@ -59,49 +59,28 @@ import elide.vm.annotations.Polyglot
 
   /**
    * ## Crypto: randomInt
+   * Public overload of [randomInt].
    * Generates a cryptographically secure random integer between the specified `min` (inclusive) and `max` (exclusive) values.
-   *
-   * See also: [Node Crypto API: `randomInt`](https://nodejs.org/api/crypto.html#cryptorandomintmin-max-callback)
-   *
    * @param min Lower bound (inclusive)
    * @param max Upper bound (exclusive)
    * @param callback Callback to receive the generated safe integer or an error.
-   * @return Unit
    */
   @Polyglot public fun randomInt(min: Value, max: Value, callback: Value)
 
   /**
    * ## Crypto: randomInt
+   * Public overload of [randomInt].
    * Generates a cryptographically secure random integer between the specified `min` (inclusive) and `max` (exclusive) values.
-   *
-   * See also: [Node Crypto API: `randomInt`](https://nodejs.org/api/crypto.html#cryptorandomintmin-max-callback)
-   *
-   * @param max
-   * @param callback
-   * @return A randomly generated safe integer between `0` (inclusive) and `max` (exclusive) or nothing if a callback was provided.
-   */
-  @Polyglot public fun randomInt(max: Value, callback: Value?)
-
-  /**
-   * ## Crypto: randomInt
-   * Generates a cryptographically secure random integer between the specified `min` (inclusive) and `max` (exclusive) values.
-   *
-   * See also: [Node Crypto API: `randomInt`](https://nodejs.org/api/crypto.html#cryptorandomintmin-max-callback)
-   *
    * @param min Lower bound (inclusive)
    * @param max Upper bound (exclusive)
-   * @return A randomly generated safe integer between `min` (inclusive) and `max` (exclusive).
    */
   @Polyglot public fun randomInt(min: Value, max: Value): Long
 
   /**
    * ## Crypto: randomInt
-   * Generates a cryptographically secure random integer between `0` (inclusive) and the specified `max` (exclusive) value.
-   *
-   * See also: [Node Crypto API: `randomInt`](https://nodejs.org/api/crypto.html#cryptorandomintmin-max-callback)
-   *
+   * Public overload of [randomInt].
+   * Generates a cryptographically secure random integer between the specified `min` (inclusive) and `max` (exclusive) values.
    * @param max Upper bound (exclusive)
-   * @return A randomly generated safe integer between `0` (inclusive) and `max` (exclusive).
    */
   @Polyglot public fun randomInt(max: Value): Long
 }

packages/graalvm/src/main/kotlin/elide/runtime/node/crypto/NodeCrypto.kt

@@ -174,22 +174,6 @@ internal class NodeCrypto private constructor () : ReadOnlyProxyObject, CryptoAP
     return randomInt(safeMin, safeMax)
   }
 
-  @Polyglot override fun randomInt(max: Value, callback: Value?) {
-    val (safeMin, safeMax) = genSafeRange(Value.asValue(0), max)
-    val safeCallback: RandomIntCallback? = callback?.let { cb ->
-      { err: Throwable?, value: Long? ->
-        cb.execute(
-          err?.let { Value.asValue(it) },
-          value?.let { Value.asValue(it) }
-        )
-      }
-    }
-
-    if (safeCallback != null) {
-      randomInt(safeMin, safeMax, safeCallback)
-    }
-  }
-
   @Polyglot override fun randomInt(max: Value): Long {
     val (safeMin, safeMax) = genSafeRange(Value.asValue(0), max)
     return randomInt(safeMin, safeMax)
@@ -219,7 +203,7 @@ internal class NodeCrypto private constructor () : ReadOnlyProxyObject, CryptoAP
         2 -> {
           if (lastIsCb) {
             // randomInt(max, callback)
-            this.randomInt(args[0], args.last())
+            this.randomInt(Value.asValue(0), args[0], args.last())
           } else {
             // randomInt(min, max)
             this.randomInt(args[0], args[1])

packages/graalvm/src/test/kotlin/elide/runtime/node/NodeCryptoTest.kt

@@ -230,7 +230,7 @@ import elide.testing.annotations.TestCase
   @Test fun `randomInt should throw a RangeError when min is greater than or equal to max`() = conforms {
 
     assertFailsWith<RangeError> { crypto.provide().randomInt(Value.asValue(10L), Value.asValue(10L)) }
-    assertFailsWith<RangeError> { crypto.provide().randomInt(Value.asValue(10L),Value.asValue( 5L)) }
+    assertFailsWith<RangeError> { crypto.provide().randomInt(Value.asValue(10L), Value.asValue( 5L)) }
   }.guest {
     //language=javascript
     """