Skip to content

Commit 35db6f2

Browse files
committed
review fixes
1 parent 1a5182b commit 35db6f2

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

lib/ex_webrtc/rtp/av1/obu.ex

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ defmodule ExWebRTC.RTP.AV1.OBU do
5858
sid: sid,
5959
payload: payload
6060
}, rest}
61+
else
62+
{:error, _} = err -> err
6163
end
6264
end
6365

test/ex_webrtc/rtp/av1/payload_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ defmodule ExWebRTC.RTP.AV1.PayloadTest do
55
alias ExWebRTC.Utils
66

77
test "parse/1 and serialize/1" do
8-
# test vectors are based on av1-rtp-spec
8+
# test vectors are based on [RTP Payload Format for AV1](https://aomediacodec.github.io/av1-rtp-spec/v1.0.0.html)
99

1010
# random av1 data, not necessarily correct
1111
av1_payload = <<0, 1, 2, 3>>

test/ex_webrtc/rtp/av1/payloader_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ defmodule ExWebRTC.RTP.AV1.PayloaderTest do
1414
{:ok, frame} = Reader.next_frame(ivf_reader)
1515
{rtp_packets, av1_payloader} = Payloader.AV1.payload(av1_payloader, frame.data)
1616

17-
# assert all packets are no bigger than 200 bytes
17+
# assert all packets are no bigger than 101 bytes
1818
rtp_packets
1919
|> Enum.each(fn rtp_packet ->
20-
assert byte_size(rtp_packet.payload) <= 200
20+
assert byte_size(rtp_packet.payload) <= 101
2121
end)
2222

2323
last_rtp = List.last(rtp_packets)

0 commit comments

Comments
 (0)