Issue a nice error when eldev-use-vc-repository is given mismatching package name and the repository.

Author: doublep

eldev-vc.el

@@ -249,6 +249,10 @@ Will be nil if no such repository was registered or
         (when commit
           (setf tag+version (eldev--vc-pick-release-tag release-tag-regexp))))
       (let ((package (eldev-package-descriptor dir)))
+        (unless (eq (package-desc-name package) (car repository))
+          (signal 'eldev-error `(:hint ("This package was expected due to a call to `eldev-use-vc-repository'
+However, the repository contains package `%s' instead" ,(package-desc-name package))
+                                 "VC repository `%s' failed to provide package `%s'" ,(eldev--vc-repository-name repository) ,(car repository))))
         (if tag+version
             (setf (package-desc-version package) (cdr tag+version))
           (eldev-call-process (eldev-git-executable) `("--no-pager" "log" "-1" "--no-color" "--format=%cI" "--no-patch")

test/vc-repositories.el

@@ -301,4 +301,18 @@
         (should (= exit-code 0))))))
 
 
+(ert-deftest eldev-vc-repositories-wrong-package ()
+  (eldev--test-with-temp-copy "dependency-e" 'Git
+    (let ((dependency-e-dir    eldev--test-project)
+          (eldev--test-project "vc-dep-project-a"))
+      (eldev--test-delete-cache)
+      ;; Make sure that such misconfiguration, i.e. when the repository doesn't provide the "promised"
+      ;; package, are caught early and result in an understandable failure.
+      (eldev--test-run nil ("--setup" `(eldev-use-vc-repository 'dependency-a :git ,dependency-e-dir)
+                            "prepare")
+        (should (string-match-p (rx-to-string `(seq ,dependency-e-dir (0+ any) "failed to provide" (0+ any) "dependency-a")) stderr))
+        (should (string-match-p (rx "repository contains package" (0+ any) "dependency-e") stderr))
+        (should (= exit-code 1))))))
+
+
 (provide 'test/vc-repositories)