Fix certain problems caused by --disable-dependencies in projects that use autoloads.

Author: doublep

eldev-build.el

@@ -374,6 +374,8 @@ This function may only be called while inside the body of a
   ;; When building, project loading mode is ignored.  The reason is that building itself
   ;; can involve compiling or packaging.
   (run-hooks 'eldev-build-system-hook)
+  (unless eldev-normal-dependency-management
+    (setf dont-touch-packages t))
   (unless dont-touch-packages
     (let ((eldev-project-loading-mode 'as-is))
       (when (memq 'test eldev-build-sets)

test/autoloads.el

@@ -102,4 +102,29 @@
       (should (= exit-code 0)))))
 
 
+(ert-deftest eldev-autoloads-disabled-dependencies ()
+  (let ((eldev--test-project "project-j"))
+    (eldev--test-delete-cache)
+    (eldev--test-run nil ("prepare")
+      (should (= exit-code 0)))
+    ;; In real use, dependency `project-i' would be found from the project sources by
+    ;; whoever sets `EMACSLOADPATH'.  Here we hardcode it to simplify things.
+    (let ((process-environment `(,(eldev--test-emacsloadpath (eldev--test-project-dir) (eldev--test-project-dir "project-i"))
+                                 ,@process-environment)))
+      ;; This would work without `--disable-dependencies', as the function should be
+      ;; autoloaded.  However, at least as of now, `--disable-dependencies' also disables
+      ;; autoload handling.  Codify this in tests to be reminded if this somehow changes.
+      ;; `project-j' itself may or may not be loaded, depending on target `:autoloads'
+      ;; being rebuilt (see also `eldev--unload-package' which is _not_ called when using
+      ;; `--disable-dependencies'); so it fails either already on `project-j-hello', or
+      ;; else on `project-i-hello'.
+      (eldev--test-run nil ("--disable-dependencies" "eval" "--dont-require" `(project-j-hello))
+        (should (string-match-p "function definition is void.+project-[ij]-hello" stderr))
+        (should (= exit-code 1)))
+      ;; Works only when requiring everything (`project-j' is autorequired by the command).
+      (eldev--test-run nil ("--disable-dependencies" "eval" `(progn (require 'project-i) (project-j-hello)))
+        (should (string= stdout "\"Hello\"\n"))
+        (should (= exit-code 0))))))
+
+
 (provide 'test/autoloads)

test/common.el

@@ -179,6 +179,10 @@ beginning.  Exit code of the process is bound as EXIT-CODE."
     ,(format "ELDEV_DIR=%s"   (eldev--test-eldev-dir))
     ,@process-environment))
 
+(defun eldev--test-emacsloadpath (&rest extras)
+  (format "EMACSLOADPATH=%s" (mapconcat #'identity (append extras load-path) path-separator)))
+
+
 (defun eldev--test-force-bootstrapping-now ()
   (eldev-call-process eldev--test-shell-command nil :die-on-error t))
 

test/test.el

@@ -175,8 +175,9 @@
 (ert-deftest eldev-test-project-c-disabled-dependencies-2 ()
   ;; Dependencies are disabled, but we supply `load-path', so testing should work.
   (let* ((eldev--test-project "project-c")
-         (process-environment `(,(format "EMACSLOADPATH=%s"
-                                         (mapconcat #'identity (append (list (eldev--test-project-dir) (eldev--test-project-dir "dependency-a")) load-path) path-separator))
+         ;; In real use, `dependency-a' would be found from the project sources by whoever
+         ;; sets `EMACSLOADPATH'.  Here we hardcode it to simplify things.
+         (process-environment `(,(eldev--test-emacsloadpath (eldev--test-project-dir) (eldev--test-project-dir "dependency-a"))
                                 ,@process-environment)))
     (eldev--test-delete-cache)
     (eldev--test-run nil ("--disable-dependencies" "test")