Update to ember 5.12

RobbieTheWagner · RobbieTheWagner · commit 5f70e6b9fca1 · 2024-10-10T10:05:57.000-04:00
diff --git a/.ember-cli b/.ember-cli
@@ -1,12 +1,4 @@
 {
-  /**
-    Ember CLI sends analytics information by default. The data is completely
-    anonymous, but there are times when you might want to disable this behavior.
-
-    Setting `disableAnalytics` to true will prevent any data from being sent.
-  */
-  "disableAnalytics": false,
-
   /**
     Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
     rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
diff --git a/.eslintignore b/.eslintignore
@@ -1,28 +1,17 @@
 # unconventional js
 /blueprints/*/files/
-/vendor/
 
 # compiled output
+/declarations/
 /dist/
-/tmp/
-
-# dependencies
-/bower_components/
-/node_modules/
 
 # misc
 /coverage/
 !.*
 .*/
-.eslintcache
 
 # ember-try
 /.node_modules.ember-try/
-/bower.json.ember-try
-/npm-shrinkwrap.json.ember-try
-/package.json.ember-try
-/package-lock.json.ember-try
-/yarn.lock.ember-try
 
 # ember-inspector specific
 /dist_prev/
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -4,10 +4,13 @@ module.exports = {
   root: true,
   parser: '@babel/eslint-parser',
   parserOptions: {
-    ecmaVersion: 2020,
+    ecmaVersion: 'latest',
     sourceType: 'module',
-    ecmaFeatures: {
-      legacyDecorators: true,
+    requireConfigFile: false,
+    babelOptions: {
+      plugins: [
+        ['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }],
+      ],
     },
   },
   plugins: ['ember'],
@@ -65,13 +68,7 @@ module.exports = {
         browser: false,
         node: true,
       },
-      plugins: ['node'],
-      extends: ['plugin:node/recommended'],
-      rules: {
-        // this can be removed once the following is fixed
-        // https://github.com/mysticatea/eslint-plugin-node/issues/77
-        'node/no-unpublished-require': 'off',
-      },
+      extends: ['plugin:n/recommended'],
     },
     {
       // test files
diff --git a/.gitignore b/.gitignore
@@ -1,24 +1,19 @@
-# See https://help.github.com/ignore-files/ for more about ignoring files.
-
 # compiled output
 /dist/
 /tmp/
 /dist_prev
 
 .DS_Store
+/declarations/
 
 # dependencies
-/bower_components/
 /node_modules/
 
 # misc
 /.env*
 /.pnp*
-/.sass-cache
 /.eslintcache
-/connect.lock
 /coverage/
-/libpeerconnection.log
 /npm-debug.log*
 /testem.log
 /yarn-error.log
@@ -28,7 +23,6 @@ config/secrets.json
 
 # ember-try
 /.node_modules.ember-try/
-/bower.json.ember-try
 /npm-shrinkwrap.json.ember-try
 /package.json.ember-try
 /package-lock.json.ember-try
diff --git a/.prettierignore b/.prettierignore
@@ -1,25 +1,13 @@
 # unconventional js
 /blueprints/*/files/
-/vendor/
 
 # compiled output
 /dist/
-/tmp/
-
-# dependencies
-/bower_components/
-/node_modules/
 
 # misc
 /coverage/
 !.*
-.eslintcache
-.lint-todo/
+.*/
 
 # ember-try
 /.node_modules.ember-try/
-/bower.json.ember-try
-/npm-shrinkwrap.json.ember-try
-/package.json.ember-try
-/package-lock.json.ember-try
-/yarn.lock.ember-try
diff --git a/.prettierrc.js b/.prettierrc.js
@@ -1,13 +1,11 @@
 'use strict';
 
 module.exports = {
-  singleQuote: true,
   overrides: [
     {
-      files: '**/*.hbs',
+      files: '*.{js,ts}',
       options: {
-        parser: 'glimmer',
-        singleQuote: false,
+        singleQuote: true,
       },
     },
   ],
diff --git a/.stylelintignore b/.stylelintignore
@@ -0,0 +1,8 @@
+# unconventional files
+/blueprints/*/files/
+
+# compiled output
+/dist/
+
+# addons
+/.node_modules.ember-try/
diff --git a/.stylelintrc.js b/.stylelintrc.js
@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
-  extends: 'stylelint-config-ship-shape',
+  extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
 };
diff --git a/.tool-versions b/.tool-versions
@@ -1,2 +1,2 @@
-nodejs 18.18.2
-pnpm 8.10.2
+nodejs 18.20.4
+pnpm 9.12.1
diff --git a/.watchmanconfig b/.watchmanconfig
@@ -1,3 +1,3 @@
 {
-  "ignore_dirs": ["tmp", "dist"]
+  "ignore_dirs": ["dist"]
 }
diff --git a/config/ember-cli-update.json b/config/ember-cli-update.json
@@ -3,15 +3,15 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "4.9.2",
+      "version": "5.12.0",
       "blueprints": [
         {
           "name": "app",
           "outputRepo": "https://github.com/ember-cli/ember-new-output",
           "codemodsSource": "ember-app-codemods-manifest@1",
           "isBaseBlueprint": true,
           "options": [
-            "--yarn",
+            "--pnpm",
             "--no-welcome"
           ]
         }
diff --git a/config/ember-try.js b/config/ember-try.js
@@ -1,14 +1,8 @@
-/* eslint-disable */
 'use strict';
 
 const getChannelURL = require('ember-source-channel-url');
 
-module.exports = function () {
-  return Promise.all([
-    getChannelURL('release'),
-    getChannelURL('beta'),
-    getChannelURL('canary'),
-  ]).then((urls) => {
+module.exports = async function () {
     return {
       usePnpm: true,
       scenarios: [
@@ -47,33 +41,43 @@ module.exports = function () {
             },
           },
         },
+        {
+          name: 'ember-lts-4.8',
+          npm: {
+            devDependencies: {
+              'ember-source': '~4.8.0',
+            },
+          },
+        },
+        {
+          name: 'ember-lts-4.12',
+          npm: {
+            devDependencies: {
+              'ember-source': '~4.12.0',
+            },
+          },
+        },
         {
           name: 'ember-release',
           npm: {
             devDependencies: {
-              'ember-source': urls[0],
-              'ember-qunit': '^7.0.0',
-              '@ember/test-helpers': '^3.0.3'
+              'ember-source': await getChannelURL('release'),
             },
           },
         },
         {
           name: 'ember-beta',
           npm: {
             devDependencies: {
-              'ember-source': urls[1],
-              'ember-qunit': '^7.0.0',
-              '@ember/test-helpers': '^3.0.3'
+              'ember-source': await getChannelURL('beta'),
             },
           },
         },
         {
           name: 'ember-canary',
           npm: {
             devDependencies: {
-              'ember-source': urls[2],
-              'ember-qunit': '^7.0.0',
-              '@ember/test-helpers': '^3.0.3'
+              'ember-source': await getChannelURL('canary'),
             },
           },
         },
@@ -91,5 +95,4 @@ module.exports = function () {
         },
       ],
     };
-  });
 };
diff --git a/config/optional-features.json b/config/optional-features.json
@@ -2,5 +2,6 @@
   "application-template-wrapper": false,
   "default-async-observers": true,
   "jquery-integration": false,
-  "template-only-glimmer-components": true
+  "template-only-glimmer-components": true,
+  "no-implicit-route-model": true
 }
diff --git a/package.json b/package.json
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tests/helpers/index.js b/tests/helpers/index.js

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "ignore_dirs": ["tmp", "dist"]`
	`2`	`+ "ignore_dirs": ["dist"]`
`3`	`3`	`}`