Merge pull request #20994 from NullVoxPopuli/nvp/renderComponent/loose-mode-interop-not-working

[BUG release] loosemode interop not working with renderComponent

Author: ef4

packages/@ember/-internals/glimmer/lib/renderer.ts

@@ -55,7 +55,6 @@ import { BOUNDS } from './component-managers/curly';
 import { createRootOutlet } from './component-managers/outlet';
 import { RootComponentDefinition } from './component-managers/root';
 import { EmberEnvironmentDelegate } from './environment';
-import { StrictResolver } from './renderer/strict-resolver';
 import ResolverImpl from './resolver';
 import type { OutletState } from './utils/outlet';
 import OutletView from './views/outlet';
@@ -345,7 +344,7 @@ interface ViewRegistry {
   [viewId: string]: unknown;
 }
 
-type Resolver = ClassicResolver | StrictResolver;
+type Resolver = ClassicResolver;
 
 interface RendererData {
   owner: object;
@@ -679,7 +678,7 @@ export class BaseRenderer {
       owner,
       { hasDOM: hasDOM, ...options },
       document as SimpleDocument,
-      new StrictResolver(),
+      new ResolverImpl(),
       clientBuilder
     );
   }
@@ -769,7 +768,7 @@ export class Renderer extends BaseRenderer {
       owner,
       { hasDOM: hasDOM, ...options },
       document as SimpleDocument,
-      new StrictResolver(),
+      new ResolverImpl(),
       clientBuilder
     );
   }

packages/@ember/-internals/glimmer/lib/renderer/strict-resolver.ts

@@ -597,6 +597,34 @@ moduleFor(
   }
 );
 
+moduleFor(
+  'Strict Mode <-> Loose Mode - renderComponent',
+  class extends RenderComponentTestCase {
+    '@test incidentally invoked loose-mode components can still resolve helpers'() {
+      this.owner.register('helper:a-helper', (str: string) => str.toUpperCase());
+      let Loose = defineComponent(null, `Hi: {{a-helper "there"}}`);
+      let Root = defComponent('<Loose />', { scope: { Loose } });
+
+      this.renderComponent(Root, { expect: 'Hi: THERE' });
+
+      run(() => destroy(this));
+
+      assertHTML('');
+    }
+
+    '@test strict-mode components cannot lookup things in the registry'(assert: Assert) {
+      this.owner.register('helper:a-helper', (str: string) => str.toUpperCase());
+      assert.throws(() => {
+        /**
+         * We need to pass a scope so that `defComponent` returns a strict-mode component.
+         */
+        let Root = defComponent('{{a-helper "hi"}}', { scope: {} });
+        this.renderComponent(Root, { expect: '' });
+      }, /but that value was not in scope: a-helper/);
+    }
+  }
+);
+
 moduleFor(
   'Strict Mode - renderComponent - built ins',
   class extends RenderComponentTestCase {