Skip to content

Commit 65e0069

Browse files
committed
fix up tests
1 parent 161ad17 commit 65e0069

File tree

9 files changed

+27
-347
lines changed

9 files changed

+27
-347
lines changed

exercises/02.metadata/03.solution.titles-with-meta/tests/e2e/metadata.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ test.describe('Routing E2E Tests', () => {
88
await expect(page).toHaveTitle('Epic Shop')
99

1010
// Check for duplicate <title> elements
11-
const titleElements = page.locator('title')
11+
const titleElements = page.locator('head > title')
1212
await expect(titleElements).toHaveCount(1)
1313
})
1414

@@ -18,7 +18,7 @@ test.describe('Routing E2E Tests', () => {
1818
await page.goto('/products')
1919
await expect(page).toHaveTitle('Epic Shop | All Products')
2020
// Check for duplicate <title> elements
21-
const titleElements = page.locator('title')
21+
const titleElements = page.locator('head > title')
2222
await expect(titleElements).toHaveCount(1)
2323
})
2424

@@ -28,7 +28,7 @@ test.describe('Routing E2E Tests', () => {
2828
await page.goto('/products/1')
2929
await expect(page).toHaveTitle('Epic Shop | Product overview')
3030
// Check for duplicate <title> elements
31-
const titleElements = page.locator('title')
31+
const titleElements = page.locator('head > title')
3232
await expect(titleElements).toHaveCount(1)
3333
})
3434
})

exercises/03.data-fetching/01.problem.fetching-with-loaders/tests/e2e/metadata.test.ts

Lines changed: 3 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,7 @@ test.describe('Routing E2E Tests', () => {
88
await expect(page).toHaveTitle('Epic Shop')
99

1010
// Check for duplicate <title> elements
11-
const titleElements = page.locator('title')
12-
await expect(titleElements).toHaveCount(1)
13-
})
14-
15-
test('should navigate to about page and render correct content', async ({
16-
page,
17-
}) => {
18-
await page.goto('/about')
19-
await expect(page).toHaveTitle('Epic Shop | About Us')
20-
// Check for duplicate <title> elements
21-
const titleElements = page.locator('title')
22-
await expect(titleElements).toHaveCount(1)
23-
})
24-
25-
test('should navigate to contact page and render correct content', async ({
26-
page,
27-
}) => {
28-
await page.goto('/contact')
29-
await expect(page).toHaveTitle('Epic Shop | Contact Us')
30-
// Check for duplicate <title> elements
31-
const titleElements = page.locator('title')
11+
const titleElements = page.locator('head > title')
3212
await expect(titleElements).toHaveCount(1)
3313
})
3414

@@ -38,27 +18,7 @@ test.describe('Routing E2E Tests', () => {
3818
await page.goto('/products')
3919
await expect(page).toHaveTitle('Epic Shop | All Products')
4020
// Check for duplicate <title> elements
41-
const titleElements = page.locator('title')
42-
await expect(titleElements).toHaveCount(1)
43-
})
44-
45-
test('should navigate to terms-of-service page and render correct content', async ({
46-
page,
47-
}) => {
48-
await page.goto('/terms-of-service')
49-
await expect(page).toHaveTitle('Epic Shop | Terms of Service')
50-
// Check for duplicate <title> elements
51-
const titleElements = page.locator('title')
52-
await expect(titleElements).toHaveCount(1)
53-
})
54-
55-
test('should navigate to terms-of-use page and render correct content', async ({
56-
page,
57-
}) => {
58-
await page.goto('/terms-of-use')
59-
await expect(page).toHaveTitle('Epic Shop | Terms of Use')
60-
// Check for duplicate <title> elements
61-
const titleElements = page.locator('title')
21+
const titleElements = page.locator('head > title')
6222
await expect(titleElements).toHaveCount(1)
6323
})
6424

@@ -68,7 +28,7 @@ test.describe('Routing E2E Tests', () => {
6828
await page.goto('/products/1')
6929
await expect(page).toHaveTitle('Epic Shop | Product overview')
7030
// Check for duplicate <title> elements
71-
const titleElements = page.locator('title')
31+
const titleElements = page.locator('head > title')
7232
await expect(titleElements).toHaveCount(1)
7333
})
7434
})

exercises/03.data-fetching/01.solution.fetching-with-loaders/tests/e2e/metadata.test.ts

Lines changed: 3 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,7 @@ test.describe('Routing E2E Tests', () => {
88
await expect(page).toHaveTitle('Epic Shop')
99

1010
// Check for duplicate <title> elements
11-
const titleElements = page.locator('title')
12-
await expect(titleElements).toHaveCount(1)
13-
})
14-
15-
test('should navigate to about page and render correct content', async ({
16-
page,
17-
}) => {
18-
await page.goto('/about')
19-
await expect(page).toHaveTitle('Epic Shop | About Us')
20-
// Check for duplicate <title> elements
21-
const titleElements = page.locator('title')
22-
await expect(titleElements).toHaveCount(1)
23-
})
24-
25-
test('should navigate to contact page and render correct content', async ({
26-
page,
27-
}) => {
28-
await page.goto('/contact')
29-
await expect(page).toHaveTitle('Epic Shop | Contact Us')
30-
// Check for duplicate <title> elements
31-
const titleElements = page.locator('title')
11+
const titleElements = page.locator('head > title')
3212
await expect(titleElements).toHaveCount(1)
3313
})
3414

@@ -38,27 +18,7 @@ test.describe('Routing E2E Tests', () => {
3818
await page.goto('/products')
3919
await expect(page).toHaveTitle('Epic Shop | All Products')
4020
// Check for duplicate <title> elements
41-
const titleElements = page.locator('title')
42-
await expect(titleElements).toHaveCount(1)
43-
})
44-
45-
test('should navigate to terms-of-service page and render correct content', async ({
46-
page,
47-
}) => {
48-
await page.goto('/terms-of-service')
49-
await expect(page).toHaveTitle('Epic Shop | Terms of Service')
50-
// Check for duplicate <title> elements
51-
const titleElements = page.locator('title')
52-
await expect(titleElements).toHaveCount(1)
53-
})
54-
55-
test('should navigate to terms-of-use page and render correct content', async ({
56-
page,
57-
}) => {
58-
await page.goto('/terms-of-use')
59-
await expect(page).toHaveTitle('Epic Shop | Terms of Use')
60-
// Check for duplicate <title> elements
61-
const titleElements = page.locator('title')
21+
const titleElements = page.locator('head > title')
6222
await expect(titleElements).toHaveCount(1)
6323
})
6424

@@ -68,7 +28,7 @@ test.describe('Routing E2E Tests', () => {
6828
await page.goto('/products/1')
6929
await expect(page).toHaveTitle('Epic Shop | Product overview')
7030
// Check for duplicate <title> elements
71-
const titleElements = page.locator('title')
31+
const titleElements = page.locator('head > title')
7232
await expect(titleElements).toHaveCount(1)
7333
})
7434
})

exercises/03.data-fetching/02.problem.search-with-url/tests/e2e/metadata.test.ts

Lines changed: 3 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,7 @@ test.describe('Routing E2E Tests', () => {
88
await expect(page).toHaveTitle('Epic Shop')
99

1010
// Check for duplicate <title> elements
11-
const titleElements = page.locator('title')
12-
await expect(titleElements).toHaveCount(1)
13-
})
14-
15-
test('should navigate to about page and render correct content', async ({
16-
page,
17-
}) => {
18-
await page.goto('/about')
19-
await expect(page).toHaveTitle('Epic Shop | About Us')
20-
// Check for duplicate <title> elements
21-
const titleElements = page.locator('title')
22-
await expect(titleElements).toHaveCount(1)
23-
})
24-
25-
test('should navigate to contact page and render correct content', async ({
26-
page,
27-
}) => {
28-
await page.goto('/contact')
29-
await expect(page).toHaveTitle('Epic Shop | Contact Us')
30-
// Check for duplicate <title> elements
31-
const titleElements = page.locator('title')
11+
const titleElements = page.locator('head > title')
3212
await expect(titleElements).toHaveCount(1)
3313
})
3414

@@ -38,27 +18,7 @@ test.describe('Routing E2E Tests', () => {
3818
await page.goto('/products')
3919
await expect(page).toHaveTitle('Epic Shop | All Products')
4020
// Check for duplicate <title> elements
41-
const titleElements = page.locator('title')
42-
await expect(titleElements).toHaveCount(1)
43-
})
44-
45-
test('should navigate to terms-of-service page and render correct content', async ({
46-
page,
47-
}) => {
48-
await page.goto('/terms-of-service')
49-
await expect(page).toHaveTitle('Epic Shop | Terms of Service')
50-
// Check for duplicate <title> elements
51-
const titleElements = page.locator('title')
52-
await expect(titleElements).toHaveCount(1)
53-
})
54-
55-
test('should navigate to terms-of-use page and render correct content', async ({
56-
page,
57-
}) => {
58-
await page.goto('/terms-of-use')
59-
await expect(page).toHaveTitle('Epic Shop | Terms of Use')
60-
// Check for duplicate <title> elements
61-
const titleElements = page.locator('title')
21+
const titleElements = page.locator('head > title')
6222
await expect(titleElements).toHaveCount(1)
6323
})
6424

@@ -68,7 +28,7 @@ test.describe('Routing E2E Tests', () => {
6828
await page.goto('/products/1')
6929
await expect(page).toHaveTitle('Epic Shop | Product overview')
7030
// Check for duplicate <title> elements
71-
const titleElements = page.locator('title')
31+
const titleElements = page.locator('head > title')
7232
await expect(titleElements).toHaveCount(1)
7333
})
7434
})

exercises/03.data-fetching/02.solution.search-with-url/tests/e2e/metadata.test.ts

Lines changed: 3 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,7 @@ test.describe('Routing E2E Tests', () => {
88
await expect(page).toHaveTitle('Epic Shop')
99

1010
// Check for duplicate <title> elements
11-
const titleElements = page.locator('title')
12-
await expect(titleElements).toHaveCount(1)
13-
})
14-
15-
test('should navigate to about page and render correct content', async ({
16-
page,
17-
}) => {
18-
await page.goto('/about')
19-
await expect(page).toHaveTitle('Epic Shop | About Us')
20-
// Check for duplicate <title> elements
21-
const titleElements = page.locator('title')
22-
await expect(titleElements).toHaveCount(1)
23-
})
24-
25-
test('should navigate to contact page and render correct content', async ({
26-
page,
27-
}) => {
28-
await page.goto('/contact')
29-
await expect(page).toHaveTitle('Epic Shop | Contact Us')
30-
// Check for duplicate <title> elements
31-
const titleElements = page.locator('title')
11+
const titleElements = page.locator('head > title')
3212
await expect(titleElements).toHaveCount(1)
3313
})
3414

@@ -38,27 +18,7 @@ test.describe('Routing E2E Tests', () => {
3818
await page.goto('/products')
3919
await expect(page).toHaveTitle('Epic Shop | All Products')
4020
// Check for duplicate <title> elements
41-
const titleElements = page.locator('title')
42-
await expect(titleElements).toHaveCount(1)
43-
})
44-
45-
test('should navigate to terms-of-service page and render correct content', async ({
46-
page,
47-
}) => {
48-
await page.goto('/terms-of-service')
49-
await expect(page).toHaveTitle('Epic Shop | Terms of Service')
50-
// Check for duplicate <title> elements
51-
const titleElements = page.locator('title')
52-
await expect(titleElements).toHaveCount(1)
53-
})
54-
55-
test('should navigate to terms-of-use page and render correct content', async ({
56-
page,
57-
}) => {
58-
await page.goto('/terms-of-use')
59-
await expect(page).toHaveTitle('Epic Shop | Terms of Use')
60-
// Check for duplicate <title> elements
61-
const titleElements = page.locator('title')
21+
const titleElements = page.locator('head > title')
6222
await expect(titleElements).toHaveCount(1)
6323
})
6424

@@ -68,7 +28,7 @@ test.describe('Routing E2E Tests', () => {
6828
await page.goto('/products/1')
6929
await expect(page).toHaveTitle('Epic Shop | Product overview')
7030
// Check for duplicate <title> elements
71-
const titleElements = page.locator('title')
31+
const titleElements = page.locator('head > title')
7232
await expect(titleElements).toHaveCount(1)
7333
})
7434
})

exercises/03.data-fetching/03.problem.filtering-and-pagination/tests/e2e/metadata.test.ts

Lines changed: 3 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,7 @@ test.describe('Routing E2E Tests', () => {
88
await expect(page).toHaveTitle('Epic Shop')
99

1010
// Check for duplicate <title> elements
11-
const titleElements = page.locator('title')
12-
await expect(titleElements).toHaveCount(1)
13-
})
14-
15-
test('should navigate to about page and render correct content', async ({
16-
page,
17-
}) => {
18-
await page.goto('/about')
19-
await expect(page).toHaveTitle('Epic Shop | About Us')
20-
// Check for duplicate <title> elements
21-
const titleElements = page.locator('title')
22-
await expect(titleElements).toHaveCount(1)
23-
})
24-
25-
test('should navigate to contact page and render correct content', async ({
26-
page,
27-
}) => {
28-
await page.goto('/contact')
29-
await expect(page).toHaveTitle('Epic Shop | Contact Us')
30-
// Check for duplicate <title> elements
31-
const titleElements = page.locator('title')
11+
const titleElements = page.locator('head > title')
3212
await expect(titleElements).toHaveCount(1)
3313
})
3414

@@ -38,27 +18,7 @@ test.describe('Routing E2E Tests', () => {
3818
await page.goto('/products')
3919
await expect(page).toHaveTitle('Epic Shop | All Products')
4020
// Check for duplicate <title> elements
41-
const titleElements = page.locator('title')
42-
await expect(titleElements).toHaveCount(1)
43-
})
44-
45-
test('should navigate to terms-of-service page and render correct content', async ({
46-
page,
47-
}) => {
48-
await page.goto('/terms-of-service')
49-
await expect(page).toHaveTitle('Epic Shop | Terms of Service')
50-
// Check for duplicate <title> elements
51-
const titleElements = page.locator('title')
52-
await expect(titleElements).toHaveCount(1)
53-
})
54-
55-
test('should navigate to terms-of-use page and render correct content', async ({
56-
page,
57-
}) => {
58-
await page.goto('/terms-of-use')
59-
await expect(page).toHaveTitle('Epic Shop | Terms of Use')
60-
// Check for duplicate <title> elements
61-
const titleElements = page.locator('title')
21+
const titleElements = page.locator('head > title')
6222
await expect(titleElements).toHaveCount(1)
6323
})
6424

@@ -68,7 +28,7 @@ test.describe('Routing E2E Tests', () => {
6828
await page.goto('/products/1')
6929
await expect(page).toHaveTitle('Epic Shop | Product overview')
7030
// Check for duplicate <title> elements
71-
const titleElements = page.locator('title')
31+
const titleElements = page.locator('head > title')
7232
await expect(titleElements).toHaveCount(1)
7333
})
7434
})

0 commit comments

Comments
 (0)